Skip to content

feat(alerts): add dedicated telegram alerts toggle button in topbar - #66

Merged
mlgitdev merged 2 commits into
mainfrom
feat/telegram-alerts-toggle-65
Nov 6, 2026
Merged

mlgitdev merged 2 commits into
mainfrom
feat/telegram-alerts-toggle-65

Conversation

@mlgitdev

@mlgitdev mlgitdev commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Summary

Introduces a Dual Independent Alert Controls Architecture by adding a dedicated topbar Telegram alert toggle button (#btn-telegram) with a custom Telegram paper plane + bell emblem, and decoupling the existing in-app audio bell (#btn-mute) so that local audio chimes can remain active while mobile/desktop Telegram push alerts are silenced with 1 click directly from the header. Resolves #65.

Motivation / Context

Active momentum day traders operating directly at their workstations frequently want to hear local audio chimes when a runner enters criteria, while silencing noisy phone/desktop Telegram push alerts. Previously, the topbar bell toggle silenced both sound and Telegram simultaneously, and toggling Telegram independently required navigating to the Settings modal. This PR delivers instant, 1-click independent alert toggles directly on the terminal topbar.

Changes

  • Dedicated Topbar Telegram Button (#btn-telegram): Added adjacent to #btn-mute with custom vector icon combining the iconic Telegram paper plane with a docked alert bell badge. Features Telegram Blue (#29b6f6) active state and red-tinted slashed emblem with pulsing alert glow (pausePulse) when paused.
  • Decoupled Audio Bell (#btn-mute): Strictly governs local terminal waveform audio chimes (alerts.mute). Muting sound no longer suppresses Telegram push alerts when Telegram is enabled.
  • Backend Alert Dispatch: Updated app/screener.py, app/tape.py, app/api.py, and app/main.py so Telegram push alert dispatching is governed exclusively by alerts.telegram_enabled.
  • Keyboard Shortcuts & Hotkeys: Added toggle_telegram configurable hotkey action and updated Settings hotkey table.
  • Comprehensive Unit Tests: Added tests/test_alert_controls.py covering all permutations of audio mute and Telegram push notification states.
  • Showcase & Visual Assets: Updated docs/img/terminal.png with the user's native full-screen capture, regenerated assets/social_preview.png, assets/hero.jpg, and web/img/hero.jpg.
  • Documentation & Specifications: Updated docs/SPEC.md, README.md, docs/wiki/ guides, and authored docs/releases/v2.12.0.md with SemVer bump to v2.12.0.

Verification & Testing

  • Windows local run verification: Compiled python bytecode across app, run_app.py, and tests with zero syntax errors.
  • Cross-Platform Parity: Verified clean platform abstraction and icon SVG geometry.
  • Unit & regression tests: Executed full test suite (python -m unittest discover tests), passing 66/66 tests.
  • Wiki synchronization: Pushed all 14 updated pages to remote GitHub Wiki (NewsAlerts.wiki.git) for v2.12.0.

Checklist

  • My PR title follows Conventional Commits: type(scope): description
  • I have filled out all sections of this PR template
  • I have verified that NO secrets, tokens, passwords, or keys are committed
  • I have updated relevant documentation in docs/ and docs/wiki/ (including version badge in _Footer.md) if applicable
  • I have verified the code locally without syntax errors or regressions

…esolves #65)

- Added dedicated topbar Telegram alert toggle button (#btn-telegram) with custom Telegram paper plane + bell icon
- Decoupled in-app audio bell (#btn-mute) to strictly govern local audio chimes without suppressing Telegram push notifications
- Updated app/screener.py, app/tape.py, app/api.py, and app/main.py for decoupled alert dispatching
- Added comprehensive unit test suite in tests/test_alert_controls.py (66/66 tests passing)
- Updated docs/img/terminal.png, assets/hero.jpg, assets/social_preview.png, and web/img/hero.jpg
- Synchronized docs/SPEC.md, README.md, docs/wiki/, and authored v2.12.0 release documentation
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

✅ PR Validation Passed

  • Conventional Commit title syntax
  • Required template sections present
  • Security audit ready

Ready for review by @mlgitdev!

…ns on app launch

- Explicitly invoked updateMuteBtn() and updateTelegramBtn() during init() in web/js/app.js
- Ensures topbar icons, titles, and .paused CSS states match persisted config.json upon initial app startup
- Added test_api_get_state_exposes_alerts_config_for_initial_launch_sync in tests/test_alert_controls.py
- Updated v2.12.0 release documentation
@mlgitdev

mlgitdev commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

🔄 Additional Fix Added

Fixed the startup alert button synchronization bug reported during testing:

  • \updateMuteBtn()\ and \updateTelegramBtn()\ are now called during \init()\ in \web/js/app.js\ upon receiving \state.config.
  • Both #btn-mute and #btn-telegram now immediately reflect their persisted paused/active visual states on startup.
  • Added unit test in \ ests/test_alert_controls.py.

@mlgitdev
mlgitdev merged commit 8c2e657 into main Nov 6, 2026
6 checks passed
@mlgitdev
mlgitdev deleted the feat/telegram-alerts-toggle-65 branch November 6, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(alerts): add dedicated telegram alerts toggle button in topbar

1 participant