Repository navigation
feat(alerts): add dedicated telegram alerts toggle button in topbar - #66
Merged
Merged
Conversation
…esolves #65) - Added dedicated topbar Telegram alert toggle button (#btn-telegram) with custom Telegram paper plane + bell icon - Decoupled in-app audio bell (#btn-mute) to strictly govern local audio chimes without suppressing Telegram push notifications - Updated app/screener.py, app/tape.py, app/api.py, and app/main.py for decoupled alert dispatching - Added comprehensive unit test suite in tests/test_alert_controls.py (66/66 tests passing) - Updated docs/img/terminal.png, assets/hero.jpg, assets/social_preview.png, and web/img/hero.jpg - Synchronized docs/SPEC.md, README.md, docs/wiki/, and authored v2.12.0 release documentation
✅ PR Validation Passed
Ready for review by @mlgitdev! |
…ns on app launch - Explicitly invoked updateMuteBtn() and updateTelegramBtn() during init() in web/js/app.js - Ensures topbar icons, titles, and .paused CSS states match persisted config.json upon initial app startup - Added test_api_get_state_exposes_alerts_config_for_initial_launch_sync in tests/test_alert_controls.py - Updated v2.12.0 release documentation
Owner
Author
🔄 Additional Fix AddedFixed the startup alert button synchronization bug reported during testing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a Dual Independent Alert Controls Architecture by adding a dedicated topbar Telegram alert toggle button (
#btn-telegram) with a custom Telegram paper plane + bell emblem, and decoupling the existing in-app audio bell (#btn-mute) so that local audio chimes can remain active while mobile/desktop Telegram push alerts are silenced with 1 click directly from the header. Resolves #65.Motivation / Context
Active momentum day traders operating directly at their workstations frequently want to hear local audio chimes when a runner enters criteria, while silencing noisy phone/desktop Telegram push alerts. Previously, the topbar bell toggle silenced both sound and Telegram simultaneously, and toggling Telegram independently required navigating to the Settings modal. This PR delivers instant, 1-click independent alert toggles directly on the terminal topbar.
Changes
#btn-telegram): Added adjacent to#btn-mutewith custom vector icon combining the iconic Telegram paper plane with a docked alert bell badge. Features Telegram Blue (#29b6f6) active state and red-tinted slashed emblem with pulsing alert glow (pausePulse) when paused.#btn-mute): Strictly governs local terminal waveform audio chimes (alerts.mute). Muting sound no longer suppresses Telegram push alerts when Telegram is enabled.app/screener.py,app/tape.py,app/api.py, andapp/main.pyso Telegram push alert dispatching is governed exclusively byalerts.telegram_enabled.toggle_telegramconfigurable hotkey action and updated Settings hotkey table.tests/test_alert_controls.pycovering all permutations of audio mute and Telegram push notification states.docs/img/terminal.pngwith the user's native full-screen capture, regeneratedassets/social_preview.png,assets/hero.jpg, andweb/img/hero.jpg.docs/SPEC.md,README.md,docs/wiki/guides, and authoreddocs/releases/v2.12.0.mdwith SemVer bump tov2.12.0.Verification & Testing
app,run_app.py, andtestswith zero syntax errors.python -m unittest discover tests), passing 66/66 tests.NewsAlerts.wiki.git) for v2.12.0.Checklist
type(scope): descriptiondocs/anddocs/wiki/(including version badge in_Footer.md) if applicable