Skip to content

feat(alerts): add dedicated telegram alerts toggle button in topbar #65

Closed

Description

@mlgitdev

Summary & Motivation

Traders frequently operate directly in front of the PC where in-app audio alert chimes are active and sufficient, making concurrent Telegram push notifications redundant or noisy. Currently, the topbar bell toggle pauses both in-app sound chimes and Telegram alerts simultaneously, while independent Telegram toggling requires navigating to the Settings modal. Traders need a dedicated topbar Telegram alert toggle icon (Telegram paper plane combined with a bell) to instantly mute or resume Telegram push notifications independently from local audio chimes with a single click.

Proposed Solution

  1. Add a second dedicated alert toggle button in the topbar (#btn-telegram-alerts) adjacent to the audio bell button.
  2. Design a custom Telegram paper plane combined with a bell SVG icon with clear active and muted states.
  3. Decouple the existing bell toggle (#btn-mute) so it strictly controls local in-app audio chimes (alerts.mute), without suppressing Telegram alerts.
  4. Wire #btn-telegram-alerts to toggle alerts.telegram_enabled, keeping it bidirectional and synchronized with Settings -> Alerts -> "Enable Telegram Alerts".
  5. Update app/screener.py, app/tape.py, app/api.py, and app/telegram.py so Telegram alert delivery is exclusively governed by telegram_enabled (and tape-specific cooldowns), independent of local audio mute.
  6. Synchronize docs/SPEC.md, user guides, release documentation, wiki, and showcase screenshots.

Technical & UI Specifications

  • Topbar UI: Add #btn-telegram-alerts beside #btn-mute in web/index.html.
  • Icon Design: Custom SVG featuring Telegram paper plane combined with a bell, with active state and slashed/paused red-glow state.
  • State Synchronization: Toggling updates App.config.alerts.telegram_enabled, saves configuration, and updates Settings UI and topbar visual indicator immediately.
  • Backend Flow: In screener.py and tape.py, decouple telegram_enabled from is_paused (mute).
  • Persistence: Preserves existing config.json schema (alerts.telegram_enabled).

Alternatives Considered

  • Keeping a single combined alert toggle and requiring users to open Settings to toggle Telegram: Rejected due to unnecessary friction during active trading.

Additional Context

Requested by user to allow quick muting of Telegram push notifications while sitting in front of the workstation without silencing local audio alerts.

Activity

  1. self-assigned this
    on Nov 6, 2026
  2. github-actions commented on Nov 6, 2026

    @github-actions

    ✅ Issue Validation Passed

    • Conventional Commit title syntax (feat(alerts))
    • Verified issue type: FEATURE
    • Required template sections present and filled out

    This issue is well-structured and ready for work according to the Issue-First Protocol.

  3. mlgitdev commented on Nov 6, 2026

    @mlgitdev
    OwnerAuthor

    🚀 Resolution In Progress

    A solution for this issue has been implemented and submitted in Pull Request #66.

    • Branch: \ eat/telegram-alerts-toggle-65\
    • PR URL: feat(alerts): add dedicated telegram alerts toggle button in topbar #66
    • Summary of Changes:
      • Added dedicated topbar Telegram alert toggle button (#btn-telegram) with custom Telegram paper plane + bell emblem.
      • Decoupled the in-app audio bell (#btn-mute) to exclusively govern local workstation sound chimes without suppressing Telegram push alerts.
      • Updated backend alert dispatching across \�pp/screener.py, \�pp/tape.py, \�pp/api.py, and \�pp/main.py.
      • Added full unit test suite in \ ests/test_alert_controls.py\ (66/66 tests passing).
      • Updated flagship screenshot \docs/img/terminal.png\ from the user's native capture, and regenerated \�ssets/social_preview.png, \�ssets/hero.jpg, and \web/img/hero.jpg.
      • Bumped application SemVer SSOT to \�2.12.0\ and synchronized \docs/SPEC.md, \README.md, release notes (\docs/releases/v2.12.0.md), and remote GitHub Wiki.

    The issue will automatically close upon PR merge into \main.

  4. mlgitdev commented on Nov 6, 2026

    @mlgitdev
    OwnerAuthor

    🔄 Additional Fix Added

    Fixed the startup state synchronization bug where the topbar alert button defaulted to the active visual state on launch regardless of the persisted configuration:

    • In \web/js/app.js, \updateMuteBtn()\ and \updateTelegramBtn()\ are now explicitly invoked during \init()\ as soon as state resolves from \get_state().
    • If either in-app audio alerts or Telegram push notifications were disabled when closing the terminal, both topbar buttons now faithfully re-render in their paused / muted state (red border, slashed icon, \pausePulse\ glow) on the next launch.
    • Added verification test in \ ests/test_alert_controls.py. Pushed to PR feat(alerts): add dedicated telegram alerts toggle button in topbar #66.
  5. mlgitdev commented on Nov 6, 2026

    @mlgitdev
    OwnerAuthor

    ✅ Release v2.12.0 Completed

    Pull Request #66 has been successfully verified across all CI runners (Windows x64, macOS arm64, Linux x64) and squash-merged into \main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions