OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volu…

[SharoonAustin06]

Why the changes were made

For the non-admin command whenever we are describing the backup it simply returns a static string, with these changes we have made it dynamic.

How to test the changes made

Create a non-admin backup for the non-admin user and try to use the oadp nonadmin describe commands with and without details flag.

Summary by CodeRabbit

• New Features

  • Backup descriptions now include a compact breakdown of backed-up pod volumes, including pod, namespace, volume name, and size.
  • When detailed information is not requested, the output shows a completion count and guidance to use --details for the full breakdown.

• Bug Fixes

  • Detailed backup information is fetched once and reused, avoiding duplicate requests and improving command efficiency.

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fe5a591c-a887-4b4f-a8ed-3599ea8d1c44

📥 Commits

Reviewing files that changed from the base of the PR and between 5080bb6 and 950c98f.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (4)

• Containerfile.download
• cmd/non-admin/backup/describe.go
• cmd/non-admin/backup/describe_test.go
• go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change upgrades the Go toolchain and dependencies. The non-admin backup description command now reuses fetched volume information and displays compact pod-volume backup details.

Changes

Backup description and toolchain updates

Layer / File(s)	Summary
Go toolchain and dependency updates Containerfile.download, go.mod	The builder and module configuration now use Go 1.26. Velero, Kubernetes, controller-runtime, YAML, and related dependencies were updated.
Backup detail retrieval and output cmd/non-admin/backup/describe.go	The command pre-fetches BackupVolumeInfos when --details is set and passes the result to both detail renderers. Pod-volume output now shows counts, hints, and compact details.
Pod-volume formatting validation cmd/non-admin/backup/describe.go, cmd/non-admin/backup/describe_test.go	New public volume-info structs and a formatter parse, filter, group, sort, and render successful pod-volume entries. Tests cover valid, empty, malformed, and unsorted input.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant RunE
  participant ProcessDownloadRequest
  participant BackupDetailRenderer
  participant CompactFormatter
  RunE->>ProcessDownloadRequest: request BackupVolumeInfos
  ProcessDownloadRequest-->>RunE: return volumeInfo
  RunE->>BackupDetailRenderer: render backup details with volumeInfo
  BackupDetailRenderer->>CompactFormatter: format pod-volume entries
  CompactFormatter-->>BackupDetailRenderer: return compact output

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the non-admin backup describe fix and the pod volume output issue. The ending is truncated, but the title remains related and sufficiently specific.
Description check	✅ Passed	The description includes both required sections. It explains the problem and gives a basic test procedure using non-admin backup describe commands with and without the details flag.
Docstring Coverage	✅ Passed	Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (2 skipped: 2 u…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

Warning

⚠️ This pull request shows signs of AI-generated slop (redundant_comments, description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hi @SharoonAustin06. Thanks for your PR.

I'm waiting for a migtools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shubham-pampattiwar]

/lgtm

[shubham-pampattiwar]

/cherry-pick oadp-1.6

[openshift-cherrypick-robot]

@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shubham-pampattiwar]

/lgtm

[sseago]

/retest

[SharoonAustin06]

/retest-required

[openshift-ci]

@SharoonAustin06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sseago]

/ok-to-test

[sseago]

/retest

[sseago]

/retest-required

[sseago]

/retest

[sseago]

/retest

[SharoonAustin06]

/retest-required

[kaovilai]

/test images

[sseago]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SharoonAustin06, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@shubham-pampattiwar: #262 failed to apply on top of branch "oadp-1.6":

Applying: OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volume Backups: <none included>
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volume Backups: <none included>

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shubham-pampattiwar]

@SharoonAustin06 Auto CP failed, please create a manual CP PR.

[SharoonAustin06]

/cherry-pick oadp-1.6

[openshift-cherrypick-robot]

@SharoonAustin06: #262 failed to apply on top of branch "oadp-1.6":

Applying: OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volume Backups: <none included>
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volume Backups: <none included>

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.