Skip to content

OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volu… - #274

Merged
openshift-merge-bot[bot] merged 2 commits into
migtools:oadp-1.6from
SharoonAustin06:OADP-7895-1.6
Sep 23, 2026
Merged

OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volu…#274
openshift-merge-bot[bot] merged 2 commits into
migtools:oadp-1.6from
SharoonAustin06:OADP-7895-1.6

Conversation

@SharoonAustin06

@SharoonAustin06 SharoonAustin06 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked PR for #262

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2a4dfbe1-4f4b-4ec4-8904-7cc065b4bac3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

sseago
sseago previously approved these changes Sep 23, 2026
View reviewed changes
@sseago

sseago commented Sep 23, 2026

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 23, 2026
@shubham-pampattiwar

shubham-pampattiwar commented Sep 23, 2026

Copy link
Copy Markdown
Member

/hold

shubham-pampattiwar
shubham-pampattiwar reviewed Sep 23, 2026
View reviewed changes
Comment thread go.mod Outdated
module github.com/migtools/oadp-cli

go 1.25.8
go 1.26.0

@shubham-pampattiwar shubham-pampattiwar Sep 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these dependency updates were present in the merged source PR. Since go.mod and go.sum conflicted while applying it to oadp-1.6, should this backport preserve the target branch dependency versions instead?

The existing Non-Admin dependency already provides the fields required by this change. @sseago, could you confirm whether carrying the Go and dependency upgrades into oadp-1.6 is intentional? If not, we should restore the target go.mod and go.sum, keep the builder on Go 1.25, and retain only the functional code and test changes.

@openshift-ci openshift-ci Bot removed the lgtm label Sep 23, 2026
@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the approved label Sep 23, 2026
@SharoonAustin06
SharoonAustin06 force-pushed the OADP-7895-1.6 branch 3 times, most recently from 2f34da4 to 465830c Compare September 23, 2026 16:12
shubham-pampattiwar
shubham-pampattiwar reviewed Sep 23, 2026
View reviewed changes
Comment thread cmd/non-admin/backup/describe.go Outdated
Joeavaikath
Joeavaikath previously approved these changes Sep 23, 2026
View reviewed changes
shubham-pampattiwar
shubham-pampattiwar reviewed Sep 23, 2026
View reviewed changes
Comment thread Containerfile.download Outdated
@openshift-ci openshift-ci Bot removed the approved label Sep 23, 2026
@kaovilai @claude @SharoonAustin06
Bump Containerfile.download builder image to golang:1.26
127dc87 
go.mod now requires go >= 1.26.0, but the image build stage still
pulled golang:1.25, failing go mod download with:
"go.mod requires go >= 1.26.0 (running go 1.25.14; GOTOOLCHAIN=local)"

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, SharoonAustin06, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Joeavaikath,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar

shubham-pampattiwar commented Sep 23, 2026

Copy link
Copy Markdown
Member

/unhold

@openshift-merge-bot
openshift-merge-bot Bot merged commit 87ff42d into migtools:oadp-1.6 Sep 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes
@Joeavaikath Joeavaikath Joeavaikath approved these changes
@sseago sseago sseago left review comments
@PrasadJoshi12 PrasadJoshi12 Awaiting requested review from PrasadJoshi12

Assignees

@sseago sseago

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SharoonAustin06 @sseago @shubham-pampattiwar @Joeavaikath @kaovilai