Repository navigation
Independently moderate newly opened issues - #2030
Stella Huang (StellaHuang95) merged 7 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Review report content independently of bot metadata, remove scheduled flag-follow-up routing, and preserve human decisions with guarded fixed replies and trusted snapshots. Verify the narrowed model runtime and independent outcomes with focused and live tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Acknowledge real author edits without another AI review, preserve renewed requests and existing comment/PR behavior, document manual budget exemptions, and request complete reads for log-heavy reports. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
d57f3dd to
08118f0
Compare
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "a201721345a92451af5d69422a473e7fa79858a0a2769bab0e9aa2720a4461ba": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
54a6e78
into
microsoft:main
## Summary Follow up on #2030 to fix two production-reproduced cases where cosmetic issue edits incorrectly acknowledged an unanswered information request. - Verify description responses against GitHub's actual body-edit history, including before/after content, editor identity, and request ordering. Title-only webhooks can contain `changes.body.from: ""`; that field alone is not proof of a response. - Ignore prose blank-line and line-ending changes without discarding meaningful indentation or blank lines in Python code, including fenced/list/indented code with tabs. - Retry transient HTTP 500/502/503/504 failures at most twice, with 1s/2s backoff and the complete live safeguards repeated before each attempt. Non-transient and exhausted failures still fail visibly. The change is limited to deterministic description-response cleanup. It does not change model classifications, add inference triggers, alter central labels, or change the seven-day closer. ## Production evidence Both cleanup defects were reproduced in [#2035](#2035), a now-closed synthetic validation fixture: | Scenario | Existing behavior | |---|---| | [Title-only update](https://github.com/microsoft/vscode-python-environments/actions/runs/44436255687) | Removed `info-needed` despite a byte-for-byte identical description. | | [Interior blank-line-only update](https://github.com/microsoft/vscode-python-environments/actions/runs/44437297451) | Removed the label without any added information. | | [Genuine description response with an API error](https://github.com/microsoft/vscode-python-environments/actions/runs/44436346435) | A GitHub HTTP 500 left the label in place until the failed job was manually rerun. | Both false acknowledgements can exclude unanswered issues from the information-needed closer. Conversely, an unrecovered API failure can leave an answered issue on that path. ## Safeguards and walkthrough - Body-edit timestamps can precede REST/webhook `updated_at` by a second, so the fix binds actual revision snapshots rather than requiring exact timestamp equality. - Undeleted empty-body revisions have `diff: null`, `deletedAt: null`; these are handled separately from missing or deleted history. - Newer requests and human activity are compared against the actual body response time, not a later rename/metadata timestamp. - Current issue/body/state/label checks and the final reread remain in place. Each retry repeats the reads, including renewed-request checks. A DELETE that succeeded despite an error is not blindly repeated. - Missing/unverifiable history defers cleanup. The existing final-read/DELETE non-atomic race remains documented. - The source documentation and generated lock metadata were updated with gh-aw v1.2.2 and the existing pinned runtime. ## Validation and review - 38 focused moderation safeguard tests pass, including the real title-webhook shape, same-second cosmetic/title events, timestamp skew, code whitespace, missing/deleted history, renewed requests, retry exhaustion, and ambiguous DELETE completion. - The regression controls reject the original merged helper. - Required lint and TypeScript compilation pass; extension unit tests: **3,573 passing, 9 pending**. - Pinned workflow compilation/no-emit validation passes with zero warnings. - **19 actual GitHub Actions-token checks** against the final helper in the private isolated fixture verify cosmetic edits retain the label, real/combined/empty-description responses clear it, code corrections count, and both central flags remain untouched. Examples: [title-only](https://github.com/StellaHuang95/issue-moderation-postmerge-check/actions/runs/44592069587), [prose blank line](https://github.com/StellaHuang95/issue-moderation-postmerge-check/actions/runs/44592138593), [combined response](https://github.com/StellaHuang95/issue-moderation-postmerge-check/actions/runs/44592295147), [code indentation](https://github.com/StellaHuang95/issue-moderation-postmerge-check/actions/runs/44592539288), [initially empty report](https://github.com/StellaHuang95/issue-moderation-postmerge-check/actions/runs/44591907981), and [empty-to-filled response](https://github.com/StellaHuang95/issue-moderation-postmerge-check/actions/runs/44593352325). Fixture links require access; no production workflow was modified for these checks. - Independent Reviewer-agent review and follow-up walkthroughs addressed the timestamp/history and code-prefix edge cases before final review. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Summary
Add a single independent GitHub Agentic Workflow for newly opened issues. It starts on
issues.opened, judges the report itself, and does not wait for central~spam/~info-neededflags. There is no hourly catch-up, flag-event router, automatic backlog sweep, or automatic AI review on edits, comments, or reopening.not_plannedinfo-needed, leave openThe information request is:
Language, spelling, brevity, a new account, missing logs, or unfilled optional fields are not sufficient grounds for closure. This version creates no
moderation-review-neededqueue label.Follow-up responses: comments and description edits
The existing reporter-comment cleanup now works for issues even without
triage-needed; existing shared-action authorization remains, and pull requests keep their previous guard.A small deterministic
issues.editedjob also treats a genuine nonempty description update by the authenticated human issue author as a response. It removes only plaininfo-needed. It does not run AI, post another comment, close/reopen an issue, or remove central flags. This prevents a reporter who fills out the requested template in the description from later being closed as unanswered.changes.title. Later or mismatched handling remains protected. Passive mentions/subscriptions are not treated as renewed requests.Independence and safeguards
--deny-tool shell --deny-tool writearguments. It reads the whole prepared file with nativeviewandforceReadLargeFiles: true; unavailable/incomplete input must produce a safe no-op. It emits only a classification. Fixed code chooses the issue, reply, labels and state change.Operation, budgets, and rollout
Manual dispatch accepts one issue number with the same human-protection guards. It is live publication, not a dry run, not a force override, and not a backlog sweep. The committed workflow exposes no staged dispatch input.
Agent execution is serialized with a 20-turn, 10-minute, 500-credit per-run limit and a separate 200-credit detector budget. The 10,000-credit daily guardrail applies to automatic runs; the pinned runtime exempts manual dispatch. Daily accounting can lag in-flight work. Missed events or failures require manual retry/review.
The source and generated executable use gh-aw v1.2.2 and pinned runtime
53d0749e19424a918acd82b4d140264ce48f2f14. Focused safeguard tests run in existing Linux/Windows unit CI jobs, and the large lockfile is marked generated. Repository/organization policy and billing must permitcopilot-requests: writeand the pinned Actions. Administrative upstream Actions policy could not be inspected with the available access (HTTP 403); no settings were changed.Review and validation
Repeated manual lifecycle review and independent code review found and fixed the description-only response gap and the same-response rename edge case. The latter was tested against actual split GitHub webhooks, not just assumed payloads. The final narrow independent review found no remaining meaningful defect in the corrections.
770d176407659ed9c39f80ef5f893a7251cafe87. No identity substitutions were used.Live end-to-end checks
These runs are in the private isolated fixture repository and require access. Actual content, comments, labels and states were asserted, not just green job conclusions.
info-needed, initially open. Runinfo-needed, leave open and add no reply. Run~spam/~info-needed. Runinfo-neededretained. Title, whitespace, emptytriage-neededrelevant; no comment, label, or closure. Final runThe earlier independent-flow checks also verified useful French reports despite misleading Bot metadata, pre-inference human-pin protection, stale-publication rejection after a body edit, and cross-issue instruction confinement. Logs and pre-cleanup outcome snapshots are retained locally. No upstream issue was created or modified.
Keep this PR draft for maintainer inspection before making it ready for review.