Repository navigation
Preserve pending information requests on cosmetic issue edits - #2044
Conversation
Verify body revision contents and author before acknowledging a response, preserve meaningful code whitespace, and retry transient failures with all live guards rechecked. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "14e3e2891a1baa005e2a36c8fa845ee9c40ed97737af5196b7b1d4932e52ae55": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Distinguish list continuation prose from actual indented code so blank-line edits do not clear pending information requests. Cover nested lists, tabs, fenced code and list boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
bc291bf
into
microsoft:main
Summary
Follow up on #2030 to fix two production-reproduced cases where cosmetic issue edits incorrectly acknowledged an unanswered information request.
changes.body.from: ""; that field alone is not proof of a response.The change is limited to deterministic description-response cleanup. It does not change model classifications, add inference triggers, alter central labels, or change the seven-day closer.
Production evidence
Both cleanup defects were reproduced in microsoft/vscode-python-environments#2035, a now-closed synthetic validation fixture:
info-neededdespite a byte-for-byte identical description.Both false acknowledgements can exclude unanswered issues from the information-needed closer. Conversely, an unrecovered API failure can leave an answered issue on that path.
Safeguards and walkthrough
updated_atby a second, so the fix binds actual revision snapshots rather than requiring exact timestamp equality.diff: null,deletedAt: null; these are handled separately from missing or deleted history.Validation and review