Skip to content

Preserve pending information requests on cosmetic issue edits - #2044

Merged
Stella Huang (StellaHuang95) merged 2 commits into
microsoft:mainfrom
StellaHuang95:stellahuang95-issue-moderation-verification
Nov 19, 2026
Merged

Stella Huang (StellaHuang95) merged 2 commits into
microsoft:mainfrom
StellaHuang95:stellahuang95-issue-moderation-verification

Conversation

@StellaHuang95

Copy link
Copy Markdown
Contributor

Summary

Follow up on #2030 to fix two production-reproduced cases where cosmetic issue edits incorrectly acknowledged an unanswered information request.

  • Verify description responses against GitHub's actual body-edit history, including before/after content, editor identity, and request ordering. Title-only webhooks can contain changes.body.from: ""; that field alone is not proof of a response.
  • Ignore prose blank-line and line-ending changes without discarding meaningful indentation or blank lines in Python code, including fenced/list/indented code with tabs.
  • Retry transient HTTP 500/502/503/504 failures at most twice, with 1s/2s backoff and the complete live safeguards repeated before each attempt. Non-transient and exhausted failures still fail visibly.

The change is limited to deterministic description-response cleanup. It does not change model classifications, add inference triggers, alter central labels, or change the seven-day closer.

Production evidence

Both cleanup defects were reproduced in microsoft/vscode-python-environments#2035, a now-closed synthetic validation fixture:

Scenario Existing behavior
Title-only update Removed info-needed despite a byte-for-byte identical description.
Interior blank-line-only update Removed the label without any added information.
Genuine description response with an API error A GitHub HTTP 500 left the label in place until the failed job was manually rerun.

Both false acknowledgements can exclude unanswered issues from the information-needed closer. Conversely, an unrecovered API failure can leave an answered issue on that path.

Safeguards and walkthrough

  • Body-edit timestamps can precede REST/webhook updated_at by a second, so the fix binds actual revision snapshots rather than requiring exact timestamp equality.
  • Undeleted empty-body revisions have diff: null, deletedAt: null; these are handled separately from missing or deleted history.
  • Newer requests and human activity are compared against the actual body response time, not a later rename/metadata timestamp.
  • Current issue/body/state/label checks and the final reread remain in place. Each retry repeats the reads, including renewed-request checks. A DELETE that succeeded despite an error is not blindly repeated.
  • Missing/unverifiable history defers cleanup. The existing final-read/DELETE non-atomic race remains documented.
  • The source documentation and generated lock metadata were updated with gh-aw v1.2.2 and the existing pinned runtime.

Validation and review

  • 38 focused moderation safeguard tests pass, including the real title-webhook shape, same-second cosmetic/title events, timestamp skew, code whitespace, missing/deleted history, renewed requests, retry exhaustion, and ambiguous DELETE completion.
  • The regression controls reject the original merged helper.
  • Required lint and TypeScript compilation pass; extension unit tests: 3,573 passing, 9 pending.
  • Pinned workflow compilation/no-emit validation passes with zero warnings.
  • 19 actual GitHub Actions-token checks against the final helper in the private isolated fixture verify cosmetic edits retain the label, real/combined/empty-description responses clear it, code corrections count, and both central flags remain untouched. Examples: title-only, prose blank line, combined response, code indentation, initially empty report, and empty-to-filled response. Fixture links require access; no production workflow was modified for these checks.
  • Independent Reviewer-agent review and follow-up walkthroughs addressed the timestamp/history and code-prefix edge cases before final review.

Verify body revision contents and author before acknowledging a response, preserve meaningful code whitespace, and retry transient failures with all live guards rechecked.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@StellaHuang95 Stella Huang (StellaHuang95) added the bug Issue identified by VS Code Team member as probable bug label Nov 19, 2026
@bschnurr

Bill Schnurr (bschnurr) commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Bill Schnurr (bschnurr) commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Reviewed commit: 31f31e9e70ebd1531fb40291b81fde42a88753b7

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "14e3e2891a1baa005e2a36c8fa845ee9c40ed97737af5196b7b1d4932e52ae55": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:changes-requested Automated review: posted blocking findings to address. label Nov 19, 2026
Distinguish list continuation prose from actual indented code so blank-line edits do not clear pending information requests. Cover nested lists, tabs, fenced code and list boundaries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added review-auto:approved Automated review: no blocking findings (approval posted). and removed review-auto:changes-requested Automated review: posted blocking findings to address. labels Nov 19, 2026
@StellaHuang95
Stella Huang (StellaHuang95) merged commit bc291bf into microsoft:main Nov 19, 2026
113 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants