Repository navigation
[S8b] Extract private workspace and document settings routing - #156
Conversation
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "fb769a9437ca97d125ecbff80a4e64092d8564baf9f26951d9fe2140703f0c4c": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Delegate settings routing to stateless private helpers while retaining live ToolServer state, public normalization seams, and distinct lookup fallbacks. Add focused facade regressions and document the private boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
## Summary - Part 1/2 of #154; S8b routing is #156. - Extract defaults and shallow workspace/fallback settings construction into private, stateless helpers. - Preserve the public `ToolServer` facade, writable dictionary identities/aliases, in-place updates, precedence, normalization, routing and lifecycle behavior. Add focused replacement/alias/context regressions without changing existing fixtures. ## Validation - Full Python suite: **353 passed**, two existing Windows symlink-privilege skips (baseline: 347 passed, same skips). - Existing flake8, Black and isort checks: pass for package and tests. - Built and non-editably installed the wheel; isolated (`-I`) installed-only imports, metadata and source hashes verified. All **119 ToolServer tests** pass against the installed artifact. - Complete-stack native consumer validation passed at `77240b0` (#156) for Pylint, Black, Flake8, isort and Mypy, with unchanged test pass/skip totals against shared baseline `664672c`. Full baseline/candidate results and installed-source proof are recorded in #156. - Native stack order verified: #155 -> #156, ultimate base `main`. No TypeScript or consumer source/test changes here. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
77240b0 to
18855ed
Compare
Pull Request is not mergeable
Summary
Part 2/2 of #154. Depends on #155; this upper layer intentionally targets
refactor/s8a-settings, notmain._routingfunctions behind the unchangedToolServerfacade.servermodule imports/normalization and URI seams.No execution/CWD resolver, backend, process/lifecycle, wire settings, dependency, TypeScript, or consumer-pin changes. The lower
_settingsextraction remains unchanged.Validation
Native Windows / Python 3.13.14, worktree-local environments:
setuptools.build_meta; installed it noneditably in an isolated native virtual environment.python -I, noPYTHONPATH, and pytest importlib mode. Verified_routing.pyin distribution metadata/RECORD, source/wheel/installed bytes, and package origins in installed site-packages before and after the tests; no checkout masking.0b0130e28c77ba94ae1f255fe05e6c222038a03b: extracted routing bodies unchanged apart from the receiver name; public method signatures/annotations, existing module imports, and all nonrouting methods unchanged.git diff --checkpasses. Final validation environments have no editable installations.Native consumer compatibility (combined stack)
All five consumers passed their complete, unchanged native
nox --session install_bundled_libs testspipelines on Windows, with Python 3.13.14 test sessions. Each comparison kept the exact consumer commit below and changed only the isolated worktree's shared-runtime gitlink from baseline664672c16ce7848f09442ce0e301279a199ceb08to candidate77240b0977e15b112599df60a436f896a5e7ef37.d5eab2852f333ac9db363acd4939ea9bb95a1edb2a12315bb60ecbbe61c224e9a12ed86c043b02a6a2c9d11e7cbc6933cfa8ea8db84b97a9ec0bebcca120a1203e8c1d9d0af36a8f7de9ae0d67da4de3047b8a10df62ab0f43ae119bece1db3ae3721a1dFor every consumer, independently verified its native noneditable bundled distribution, private identity/provenance, and bundled server import origin. The complete installed Python filename set and contents match pinned Git objects (14 baseline modules, 16 candidate modules; universal-newline normalization only), including both new private helpers. No consumer source, tests, fixtures, requirements, or tracked artifacts were changed. Existing Windows file-descriptor cleanup warnings remain nonfatal; no failures or additional skips.
Native stack verified: #155 -> #156, ultimate base
main. No merge or auto-merge was performed. Both PRs' hosted test/lint/build checks pass, including Python 3.10-3.14 on Ubuntu and Windows. This is automated compatibility evidence, not a manual VS Code smoke test.Closes #154.