Repository navigation
chore: adopt S8 shared runtime - #669
Conversation
Pin the shared runtime to merged S8 commit 89cb5fc78d32dbdf5eb7d38d2b2bd78f0e6798a2 without changing Mypy behavior or test dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "fe4ee32af91a57e7cd3063bf98ec69f496fbaecbff98b3a3d323dab4a340784e": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
external/vscode-common-python-lspfrom664672c16ce7848f09442ce0e301279a199ceb08to exact merged S8 commit89cb5fc78d32dbdf5eb7d38d2b2bd78f0e6798a2([S8a] Extract private Python settings/default helpers vscode-common-python-lsp#155 and [S8b] Extract private workspace and document settings routing vscode-common-python-lsp#156).77240b0977e15b112599df60a436f896a5e7ef37.${nearestConfig}, existing tests and the S7 test-only nox dependency fix. No API migration, source edits, requirements upgrades, formatting or generated dependency metadata changes.Validation
Verified current
main/ adoption base:047b8a10df62ab0f43ae119bece1db3ae3721a1d.PYTHONPATH,NOX_DOWNLOAD_PYTHON=never, and existing environments:python -m nox --reuse-existing-virtualenvs --session install_bundled_libs tests --report <session-report>.${nearestConfig}, daemon and non-daemon paths. Same counts as the exact consumer-base baseline and prior S8 candidate.python -I verify_s8_native_bundle.py <worktree>passed: the complete 16 Python module filenames and contents match pinned Git objects (universal-newline normalization only), with privatevscode-python-tool-internalidentity, native noneditable local-build provenance and imports from the actualbundled/libsinstallation. NoPYTHONPATHmasking, metadata patching or artificial installation path.git diff --checkpasses; cumulative tracked diff is the gitlink only. No applicable source-format/lint files changed.Manual VS Code smoke tests were not performed. This is an ordinary PR; no merge or auto-merge is requested.