Skip to content

chore: adopt S8 shared runtime - #669

Merged
Eduardo Villalpando Mello (edvilme) merged 2 commits into
mainfrom
chore/adopt-s8-runtime
Nov 17, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 2 commits into
mainfrom
chore/adopt-s8-runtime

Conversation

@edvilme

Copy link
Copy Markdown
Contributor

Summary

Validation

Verified current main / adoption base: 047b8a10df62ab0f43ae119bece1db3ae3721a1d.

  • Full unchanged native Windows pipeline, with the read-only Python 3.13.14 bootstrap, cleared PYTHONPATH, NOX_DOWNLOAD_PYTHON=never, and existing environments:
    python -m nox --reuse-existing-virtualenvs --session install_bundled_libs tests --report <session-report>.
  • Both nox sessions succeeded. 87 Python tests passed, 2 unchanged Windows symlink-privilege skips; 21 build tests passed. Full native selectors retained, including project-settings/defaults, ${nearestConfig}, daemon and non-daemon paths. Same counts as the exact consumer-base baseline and prior S8 candidate.
  • Three existing/nonfatal Windows file-descriptor cleanup warnings; no failures or additional skips.
  • After native installation, isolated python -I verify_s8_native_bundle.py <worktree> passed: the complete 16 Python module filenames and contents match pinned Git objects (universal-newline normalization only), with private vscode-python-tool-internal identity, native noneditable local-build provenance and imports from the actual bundled/libs installation. No PYTHONPATH masking, metadata patching or artificial installation path.
  • git diff --check passes; cumulative tracked diff is the gitlink only. No applicable source-format/lint files changed.

Manual VS Code smoke tests were not performed. This is an ordinary PR; no merge or auto-merge is requested.

Pin the shared runtime to merged S8 commit 89cb5fc78d32dbdf5eb7d38d2b2bd78f0e6798a2 without changing Mypy behavior or test dependencies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
@edvilme Eduardo Villalpando Mello (edvilme) added the debt Technical debt or repo cleanup label Nov 17, 2026
@bschnurr

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Reviewed commit: 35ff9df1d9d7bbfa132746ba602e01aa5dc37514

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "fe4ee32af91a57e7cd3063bf98ec69f496fbaecbff98b3a3d323dab4a340784e": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 17, 2026

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 4aabb79 into main Nov 17, 2026
26 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the chore/adopt-s8-runtime branch November 17, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt or repo cleanup review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants