You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(core): docusaurus serve serves folders with a dot in their name (AI-assisted) - #12896
docusaurus serve answers 404 for pages in folders with a dot in their name, like a docs version (/docs/2.x/) or a package name (/docs/lodash.debounce/). serve-handler sees an extension (.x), finds a folder instead of a file, and doesn't look for its index.html.
vercel/serve-handler#230 fixes it upstream, but serve-handler 6.1.8 isn't published yet: 6.1.7 is the latest version on npm. Until then, docusaurus serve passes serve-handler an lstat method that hides these folders, so serve-handler falls back to their index.html, like the upstream fix does. The TODO says to remove it after the release.
Like other URLs with an extension, these folders don't get the trailingSlash: true redirect: /docs/2.x serves docs/2.x/index.html directly.
Test Plan
pnpm test packages/docusaurus/src/commands/serve: the docs/2.x and docs/lodash.debounce rows serve their index.html, and the edge case test is flipped to "serves the index.html of folders with a dot in their name".
Fixed page serving for directories with dots in their names, including versioned documentation paths and names such as lodash.debounce. Their index pages now load correctly at root and base URLs, regardless of the trailing-slash setting.
No actionable comments were generated in the recent review.
Walkthrough
The serve request handler now supplies a custom filesystem check that reports dotted directories as missing paths. Request tests expect those directories to serve their index.html files across the tested base URL and trailing-slash settings.
Snapshots expect dotted directories to serve their index files with base URLs / and /base/. They also cover trailing-slash redirects and the /docs/2.x/ edge case.
meta/docusaurus#12865: Extracts createServeRequestHandler and its serve-handler call, which this change extends with a custom lstat method.
Merge Risk: Minimal · up to 6d321
The dotted-folder serving change is ready to merge after normal checks. The reported CI failure is unrelated to this change.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the fix for serving folders with dots in their names.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
docusaurus serveanswers 404 for pages in folders with a dot in their name, like a docs version (/docs/2.x/) or a package name (/docs/lodash.debounce/). serve-handler sees an extension (.x), finds a folder instead of a file, and doesn't look for itsindex.html.vercel/serve-handler#230 fixes it upstream, but serve-handler 6.1.8 isn't published yet: 6.1.7 is the latest version on npm. Until then,
docusaurus servepasses serve-handler anlstatmethod that hides these folders, so serve-handler falls back to theirindex.html, like the upstream fix does. TheTODOsays to remove it after the release.Like other URLs with an extension, these folders don't get the
trailingSlash: trueredirect:/docs/2.xservesdocs/2.x/index.htmldirectly.Test Plan
pnpm test packages/docusaurus/src/commands/serve: thedocs/2.xanddocs/lodash.debouncerows serve theirindex.html, and the edge case test is flipped to "serves the index.html of folders with a dot in their name".Test links
Deploy preview: https://deploy-preview-12896--docusaurus-2.netlify.app/
Related issues/PRs
docusaurus servehandles pages that look like assets (AI-assisted) #12892 capture the bug(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit
lodash.debounce. Their index pages now load correctly at root and base URLs, regardless of the trailing-slash setting.