Skip to content

Improve portablility for non-gnu libc targets #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barab00lka wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve portablility for non-gnu libc targets #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c5021
Update error.c
barab00lka Nov 9, 2026
b08173f
Update queue.h
barab00lka Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/compat/sys/queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#ifndef _SYS_QUEUE_H_
#define _SYS_QUEUE_H_

#include <sys/cdefs.h>

/*
* This file defines four types of data structures: singly-linked lists,
Expand Down
7 changes: 2 additions & 5 deletions lib/libpe/error.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,9 @@ void pe_error_print(FILE *stream, pe_err_e error) {
// Since we define _GNU_SOURCE in our Makefile, strerror_r should be GNU-compliant.
// However, looks like if you're on macOS, strerror_r is XSI-compliant.

#if defined(__DARWIN_C_LEVEL) // XSI-compliant
/* int ret = */ strerror_r(errno, errmsg, sizeof errmsg);
const char *errmsg_ptr = errmsg;
#elif defined(_GNU_SOURCE) // GNU-specific
#if defined(__GLIBC__) && defined(_GNU_SOURCE) // we have GNU strerror_r
const char *errmsg_ptr = strerror_r(errno, errmsg, sizeof errmsg);
#else // Fallback to XSI-compliant
#else // we don't have it
/* int ret = */ strerror_r(errno, errmsg, sizeof errmsg);
const char *errmsg_ptr = errmsg;
#endif
Expand Down