Repository navigation
Improve portablility for non-gnu libc targets - #239
Open
barab00lka wants to merge 2 commits into
Open
barab00lka wants to merge 2 commits into
barab00lka wants to merge 2 commits into
Conversation
This change makes checking for availability of strerror_r more portable (take musl libc into account for example). If you have GNU_SOURCE defined that does not always mean that you are using glibc therefore strerror_r may be the POSIX variant not GNU. Should not break MacOS compatibility either
This removes the unneeded internal header <sys/cdefs.h> as musl does not provide it (its an internal glibc header that serves close to no purpose and may be left out) see: https://wiki.musl-libc.org/faq.html#Q:-When-compiling-something-against-musl,-I-get-error-messages-about-%3Ccode%3Esys/cdefs.h%3C/code%3E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this small change let me build the project on a musl libc linux distribution and supposedly should not break mac os or other targets