Repository navigation
Conversation
Add a temporary workflow that runs `pie install maxmind-db/reader-ext:1.15.0` on a Windows runner. The Windows zips on the v1.15.0 release use a commit SHA where PIE expects the version, so the job is expected to fail until the zips are renamed. This commit is a test only. Do not merge it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test only. Do not merge. Close this pull request when the test is done.
This pull request adds one temporary workflow. It runs
pie install maxmind-db/reader-ext:1.15.0on a Windows runner to check whether PIE can find the Windows binaries on the v1.15.0 release.PIE builds the zip name from the package version. For PHP 8.4, non-thread-safe, x64, it asks for
php_maxminddb-v1.15.0-8.4-nts-vs17-x86_64.zip. The release hasphp_maxminddb-135915ad1ce99520fccfebb8f4ce53cf848dcc78-8.4-nts-vs17-x86_64.zip, with a commit SHA where PIE expects the version. Thesmokejob inrelease.ymlruns PIE only on Linux, so nothing checks the Windows names.Expected results:
php_maxminddb-v1.15.0-…names: rerun the job. It should pass.The
Releaseworkflow also runs on this pull request, as on any pull request. It builds and checks every platform and publishes nothing.🤖 Generated with Claude Code