Repository navigation
Conversation
PIE downloads a Windows zip by a name that has the package version in it, for example php_maxminddb-v1.15.0-8.4-nts-vs17-x86_64.zip. It then loads the DLL in the zip by the same name. php-windows-builder puts its extension-ref in both names. We passed the submodule commit SHA as that ref, so PIE could not install v1.14.0 or v1.15.0 on Windows. Tag the submodule commit on the runner and pass the checked-out submodule as extension-url with the tag as extension-ref. The builder still builds the same commit as the Linux and macOS lanes, and the zip, DLL and PDB now have the tag in their names. The windows-matrix job uses a pinned PHP version list, so it needs neither input. STF-2465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
verify-assets and publish counted the Windows zips but did not check their names, so the v1.14.0 and v1.15.0 releases shipped zips that PIE cannot find. collect-assets.sh now requires one zip for each leg of the Windows matrix, named as PIE expects, with a DLL of the same name in it. PIE loads the DLL by that name. The check accepts any compiler, because the matrix does not give it. php-windows-builder drops a PHP version it does not support from the matrix without a message. The script now also requires the matrix to build exactly the PHP versions from setup. STF-2465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
collect-assets.sh now reads the Windows matrix, so it can count the legs itself. This removes the count step from windows-matrix, its output, and WINDOWS_COUNT from verify-assets and publish. The count step also accepted a bare-array matrix, which strategy.matrix does not allow. The PHP-version check moves above the count, because the count trusts the matrix too. An empty or unset matrix now fails that check. STF-2465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abd8819 to
d890c59
Compare
PIE cannot install v1.14.0 or v1.15.0 on Windows. PIE downloads the Windows zip by a name with the package version in it, for example
php_maxminddb-v1.15.0-8.4-nts-vs17-x86_64.zip. It then loads the DLL in the zip by the same name. The release workflow passed the submodule commit SHA to php-windows-builder asextension-ref, and the builder puts that ref in both names. #24 shows the failure on a Windows runner.Changes
windowsjob tags the submodule commit with the release tag on the runner. It then passes the checked-out submodule asextension-urland the tag asextension-ref. The builder still builds the submodule commit, the same commit as the Linux and macOS lanes. The zip, DLL and PDB now have the tag in their names.setupno longer computesext-ref.windows-matrixdropsextension-urlandextension-ref, because its pinnedphp-version-listmeans it fetches nothing.collect-assets.sh, run byverify-assetsandpublish, now requires one zip for each leg of the Windows matrix, named as PIE expects. The DLL in each zip must have the same name. It accepts any compiler, because the matrix does not give it.collect-assets.shalso requires the Windows matrix to build exactly the PHP versions fromsetup. php-windows-builder drops a PHP version that it does not support without a message.collect-assets.shcounts the Windows assets from the matrix. This removes the count step fromwindows-matrixandWINDOWS_COUNT.A rename of the existing release assets does not fix them, because the DLL inside each zip also has the SHA in its name. A new release will fix this separately.
Verification
git fetch --depth=1 origin <tag>with a local path asorigin) gets commit135915afrom a shallow submodule checkout.collect-assets.shwith the 41 v1.15.0 asset names fails on the SHA names and passes with the tag in the names. It also fails in these cases:STF-2469 tracks a
pie installtest on Windows in the release workflow.🤖 Generated with Claude Code
Summary by CodeRabbit