Skip to content

Name the Windows release zips as PIE expects (STF-2465) - #25

Open
oschwald wants to merge 3 commits into
mainfrom
greg/stf-2465-windows-release-zips-of-maxmind-dbreader-ext
Open

oschwald wants to merge 3 commits into
mainfrom
greg/stf-2465-windows-release-zips-of-maxmind-dbreader-ext

Conversation

@oschwald

@oschwald oschwald commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

PIE cannot install v1.14.0 or v1.15.0 on Windows. PIE downloads the Windows zip by a name with the package version in it, for example php_maxminddb-v1.15.0-8.4-nts-vs17-x86_64.zip. It then loads the DLL in the zip by the same name. The release workflow passed the submodule commit SHA to php-windows-builder as extension-ref, and the builder puts that ref in both names. #24 shows the failure on a Windows runner.

Changes

  • The windows job tags the submodule commit with the release tag on the runner. It then passes the checked-out submodule as extension-url and the tag as extension-ref. The builder still builds the submodule commit, the same commit as the Linux and macOS lanes. The zip, DLL and PDB now have the tag in their names.
  • setup no longer computes ext-ref. windows-matrix drops extension-url and extension-ref, because its pinned php-version-list means it fetches nothing.
  • collect-assets.sh, run by verify-assets and publish, now requires one zip for each leg of the Windows matrix, named as PIE expects. The DLL in each zip must have the same name. It accepts any compiler, because the matrix does not give it.
  • collect-assets.sh also requires the Windows matrix to build exactly the PHP versions from setup. php-windows-builder drops a PHP version that it does not support without a message.
  • collect-assets.sh counts the Windows assets from the matrix. This removes the count step from windows-matrix and WINDOWS_COUNT.

A rename of the existing release assets does not fix them, because the DLL inside each zip also has the SHA in its name. A new release will fix this separately.

Verification

  • The fetch the builder runs (git fetch --depth=1 origin <tag> with a local path as origin) gets commit 135915a from a shallow submodule checkout.
  • collect-assets.sh with the 41 v1.15.0 asset names fails on the SHA names and passes with the tag in the names. It also fails in these cases:
    • A zip contains a DLL with the SHA in its name.
    • A zip is damaged.
    • One leg is missing.
    • The matrix lacks a PHP version, or is empty or unset.
  • actionlint and zizmor report no findings.

STF-2469 tracks a pie install test on Windows in the release workflow.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Release Improvements
    • Windows release builds now use the checked-out source matching the release tag.
    • Release packaging verifies that Windows assets match the release tag, PHP version, thread-safety mode, and architecture; releases fail if a required asset is missing.

PIE downloads a Windows zip by a name that has the package version in it,
for example php_maxminddb-v1.15.0-8.4-nts-vs17-x86_64.zip. It then loads
the DLL in the zip by the same name. php-windows-builder puts its
extension-ref in both names. We passed the submodule commit SHA as that
ref, so PIE could not install v1.14.0 or v1.15.0 on Windows.

Tag the submodule commit on the runner and pass the checked-out
submodule as extension-url with the tag as extension-ref. The builder
still builds the same commit as the Linux and macOS lanes, and the zip,
DLL and PDB now have the tag in their names. The windows-matrix job uses
a pinned PHP version list, so it needs neither input.

STF-2465

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oschwald
oschwald requested review from horgh and a balanced review from Copilot November 19, 2026 18:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5090940a-8869-4cf2-a8d4-cbc28d4cde52
Commits

Reviewing files that changed from the base of the PR and between cba2572 and d890c59.

Files selected for processing: 2

  • .github/workflows/release.yml
  • dev-bin/collect-assets.sh

No actionable comments were generated in the recent review.

Walkthrough

The release workflow now builds Windows assets from the checked-out submodule using a local release tag. Asset verification and publishing pass the Windows matrix to collect-assets.sh, which checks for matching Windows ZIP files.

Changes: Windows release workflow

Layer / File(s) Summary
Build Windows assets
.github/workflows/release.yml
The workflow removes the separate extension ref inputs, tags the checked-out submodule with the release tag, and uses that checkout for the Windows build.
Verify Windows release assets
.github/workflows/release.yml, dev-bin/collect-assets.sh
The verification and publishing jobs pass the Windows matrix to collect-assets.sh. The script checks for a Windows ZIP matching each matrix build’s tag, PHP version, TS mode, and architecture. It maps x64 to x86_64 and accepts any two-digit vs compiler version.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Workflow as Release workflow
  participant Build as Windows build action
  participant Collect as collect-assets.sh
  Workflow->>Build: Build from checked-out submodule with release tag
  Build->>Collect: Provide Windows ZIP asset
  Workflow->>Collect: Pass generated Windows matrix
  Collect->>Collect: Check ZIP names against matrix build tuples
Loading

Suggested reviewers: horgh

Merge Risk: Minimal · previous review cba25

This change fixes the naming of Windows release zips so PIE can install them, and asset collection now fails if a Windows matrix leg lacks a correctly named zip. No merge-blocking risk was found. The Windows build job will first run on a Windows runner at the next release.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Windows release zips are renamed to match the PIE naming scheme. The objectives confirm the zip, DLL, and PDB names now use the release tag instead of the submodule co…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the main change: Windows release zips are renamed to match the PIE naming scheme. The objectives confirm the zip, DLL, and PDB names now use the release tag instead of the submodule commit SHA, and collect-assets.sh enforces that naming. The title does not mention the tag-based naming or the asset-collection check, but it covers the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the tag with care
The Windows builds hop through the air
Each ZIP meets its matrix mate
The release checks the names and date
Then off I bounce, with carrots to spare

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d559686e-2351-400a-b395-e75d45a20922
Commits

Reviewing files that changed from the base of the PR and between 53aeca6 and cba2572.

Files selected for processing: 2

  • .github/workflows/release.yml
  • dev-bin/collect-assets.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@oschwald
oschwald requested a balanced review from Copilot and removed request for horgh November 19, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

oschwald and others added 2 commits November 19, 2026 19:04
verify-assets and publish counted the Windows zips but did not check
their names, so the v1.14.0 and v1.15.0 releases shipped zips that PIE
cannot find. collect-assets.sh now requires one zip for each leg of the
Windows matrix, named as PIE expects, with a DLL of the same name in it.
PIE loads the DLL by that name. The check accepts any compiler, because
the matrix does not give it.

php-windows-builder drops a PHP version it does not support from the
matrix without a message. The script now also requires the matrix to
build exactly the PHP versions from setup.

STF-2465

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
collect-assets.sh now reads the Windows matrix, so it can count the
legs itself. This removes the count step from windows-matrix, its
output, and WINDOWS_COUNT from verify-assets and publish. The count
step also accepted a bare-array matrix, which strategy.matrix does not
allow.

The PHP-version check moves above the count, because the count trusts
the matrix too. An empty or unset matrix now fails that check.

STF-2465

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oschwald
oschwald force-pushed the greg/stf-2465-windows-release-zips-of-maxmind-dbreader-ext branch from abd8819 to d890c59 Compare November 19, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants