Skip to content

Fix Favorites UUID hydration and unify Worker delivery - #90

Merged
RCmerci merged 5 commits into
mainfrom
fix/unify-worker-hydration
Oct 17, 2026
Merged

RCmerci merged 5 commits into
mainfrom
fix/unify-worker-hydration

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Favorites with four background outline dependencies could reserve every hydration slot without returning those requests to transport. UUID titles then remained literal in the list and its opened detail, even when the target page existed. Dispatch demands once at the public Runtime boundary and share Application-to-DB-Worker admission, delivery and terminal ownership. Retain retired graph Worker leases through terminal delivery so an old cancellation cannot publish a new-scope error or clear its refresh.

  • Keep queued/dispatched identities exclusive, preserve the four-read background bound and foreground reads, and settle every unsent demand after refusal without hidden send retries. Route Favorites, admission and ordinary graph completions through one adapter while retaining Copy/media/asset state ownership.
  • Connect Favorite Page titles and displayed Page detail root titles to reference discovery, and render Favorite Pages with the shared lookup. Keep page-first lookup, outline fallback only for explicit Missing Page, and non-clickable [[uuid]] expansions.
  • Correct native provenance to allow legal elimination of an unused original XMLm unit. Schema 2 binds actual object-only argv, compiler, original archive/unit/object bytes and pinned Git source identities; records observed unit retention accurately; and rejects unresolved XMLm and unbound inputs. Legacy schema 1/receipts remain supported. No Dune, protected interface, dependency pin or production anchor changes.

Validation:

  • Fresh private locked switch: Release @all and full runtest passed, including 21 Alcotest suites / 907 cases and 87 separate standalone PASS records.
  • Build owner: 46 tests passed with no skips. Real compiler/linker regressions were RED before each correction; a separate contract review closed seven evidence-backed findings. Whole-PR independent re-review completed on fec63d8 in a separate session; the P2 is closed and no other evidence-backed substantive findings remain.
  • Formal Simulator build 1.5877.35 at source/native revision fec63d8 completed input revalidation, target C/Swift compilation, final provider checks and signing. On A135, a cold-start read-only test restored the existing selected RTC graph, then verified the original Favorite and opened detail against the resolved title hash: no literal token, zero links, detail static text, Back complete. One UI case passed in 7.090s; outbox counts stayed zero. The preceding34 run had explicitly selected that graph, and the same exact root UUID/hash and retained data identify this sample. Page-specific fixes are covered at the public owner boundary; no separate real-graph Favorite Page example is claimed.
  • Independent full-PR review identified a P2 in App scope retirement. A genuine delayed old Worker cancellation through the public mounted App fixture produced a visible current-scope error before the fix and passes afterward; all120 Application owner cases pass. The independent re-review of the full final diff closed the P2. Exact-head CI on fec63d8 passed: run39012908637, including46 helper tests/no skips, full21 suites/907 cases+87 standalone PASS, native embed and final input verification. WIP check also passed.
  • The Simulator uses experimental Host ARM64 restamping, cross_abi_validated=false; this is not full OCaml iOS cross-compilation/ABI acceptance. The native macOS phase passed; the macOS App then hit the existing JournalChrome.swift listSectionSpacing platform restriction, so no macOS App success is claimed.
  • Both new decision documents validate. The all-document check retains three pre-existing unrelated format failures. No phone install, graph edit or merge.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T06:28:08.985126Z 994cfd5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 9fc3c89 into main Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant