Repository navigation
Fix Favorites UUID hydration and unify Worker delivery - #90
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Favorites with four background outline dependencies could reserve every hydration slot without returning those requests to transport. UUID titles then remained literal in the list and its opened detail, even when the target page existed. Dispatch demands once at the public Runtime boundary and share Application-to-DB-Worker admission, delivery and terminal ownership. Retain retired graph Worker leases through terminal delivery so an old cancellation cannot publish a new-scope error or clear its refresh.
[[uuid]]expansions.Validation:
@alland fullruntestpassed, including 21 Alcotest suites / 907 cases and 87 separate standalone PASS records.fec63d8in a separate session; the P2 is closed and no other evidence-backed substantive findings remain.fec63d8completed input revalidation, target C/Swift compilation, final provider checks and signing. On A135, a cold-start read-only test restored the existing selected RTC graph, then verified the original Favorite and opened detail against the resolved title hash: no literal token, zero links, detail static text, Back complete. One UI case passed in 7.090s; outbox counts stayed zero. The preceding34 run had explicitly selected that graph, and the same exact root UUID/hash and retained data identify this sample. Page-specific fixes are covered at the public owner boundary; no separate real-graph Favorite Page example is claimed.fec63d8passed: run39012908637, including46 helper tests/no skips, full21 suites/907 cases+87 standalone PASS, native embed and final input verification. WIP check also passed.cross_abi_validated=false; this is not full OCaml iOS cross-compilation/ABI acceptance. The native macOS phase passed; the macOS App then hit the existingJournalChrome.swiftlistSectionSpacingplatform restriction, so no macOS App success is claimed.