Repository navigation
Skip macOS App stages when producing Simulator native inputs - #92
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating Simulator host OCaml evidence previously continued into unrelated macOS Swift, packaging and signing. Add
macos --producer-only --switch ...to stop after native production and final input validation, returning an immutable schema-2 envelope andstatus: native-produced.The mode keeps cache/switch locks, locked preflight, source/compiler/dependency identity, current Dune argv and original archive/unit proofs. It removes host DNS/crypto only from an owned archive copy, binds runtime headers before handoff, validates runtime/mldoc retention and rechecks live inputs. Warm reuse reads the current Dune rule and importer ancestry/bytes. A producer receipt cannot authorize historical target inputs. The normal experimental Simulator path still compiles target C/Swift and verifies providers, platforms and signing;
cross_abi_validated=false.This PR is stacked on #90, base
fec63d8f97a0dbf5c3cf519f59bcc6a45cbf1978. No protected spec/Dune/pin or product UI change.Validation:
f26a2fd7deba7cf6335701bc498095c7674e5058found no open actionable issues after closing both code findings and the stale documentation note.f26a2fd: 54 helper tests (69.293s), all targets/native embed, full regressions and final cache-input sealing; PR build-and-test and WIP both passed.One bounded cold/hot pair on clean source/native
801cddf, one prepared compiler/locks/SDKs, Release/jobs=2 and the same absolute native cache path:Both cold native traces show 268 OCaml compile calls, 11 archive calls, one complete-object link and three C compilations; both hot traces show zero compile/archive/link actions. Producer relinking runs once cold and zero times hot, proving reuse beyond directory existence.
The auxiliary legacy macOS App failed at
listSectionSpacing; packaging/signing did not run and their saving is unmeasured. Observed recovery-route totals were 112.731→70.053s cold and 18.944→12.991s hot, not a strict successful-App end-to-end acceleration claim. Fourteen rebuilt archive hashes differ only in date metadata (all member payloads identical), selecting different Simulator namespaces. A successful full-macOS-App baseline and exact equivalent end-to-end saving are not established. Cold means a fresh owned build cache, not cold OS caches or a dependency reinstall. Resource/approval/setup waits are excluded. Raw argv, traces, phase logs and artifact/receipt hashes are retained outside the checkout.