agent_simulation: add stable id to Scenario and ScenarioGroup - #1785
Merged
Conversation
Labels, instructions, and expectations all change over a scenario's life, so nothing today correlates runs of the same scenario across time. The id is authored in scenarios.yaml and carried through the run so dashboards can chart a scenario's success rate over time.
|
theomonnom
approved these changes
Sep 8, 2026
Scenario and ScenarioGroup ids are guids from the shared generator with these prefixes, matching every other LiveKit entity id.
Contributor
Author
|
Done: ids are now generated with the shared guid utility, prefixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds `id` to `Scenario` and `ScenarioGroup`.
Today nothing correlates runs of the same scenario over time: the label, instructions, and agent expectations can all be edited, and hashing the content would make every edit a new identity. A user-authored `id` in `scenarios.yaml` gives dashboards a stable key for charting a scenario's success rate across runs. The group-level `id` does the same for the scenarios file as a whole. Run-level identity already exists as `SimulationRun.id`.
Companion CLI change: livekit/livekit-cli (requires IDs in scenarios.yaml and offers to insert them).