feat(simulate): require stable ids in scenarios.yaml, offer to add them - #970
Draft
u9g wants to merge 1 commit into
Draft
feat(simulate): require stable ids in scenarios.yaml, offer to add them#970u9g wants to merge 1 commit into
u9g wants to merge 1 commit into
Conversation
Labels, instructions, and expectations all change over a scenario's life, so nothing correlates runs of the same scenario across time. Each scenario and the file itself now carry an id that is sent with the run. Ids are generated with protocol's shared guid utility, prefixed SCN_ (scenario) and SCNG_ (scenario group). When a file is missing ids, the CLI offers to insert them in place, preserving comments, key order, and indentation.
Contributor
Author
|
Ids now come from protocol's shared guid utility with stable prefixes: |
u9g
force-pushed
the
jason/scenario-yaml-ids
branch
from
September 9, 2026 12:16
c674dde to
77a0cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on livekit/protocol#1785 (adds
Scenario.idandScenarioGroup.id). go.mod is pinned to that branch's commit so CI builds; bump to the merged version before merging this.Why
Today nothing correlates runs of the same scenario over time: the label, instructions, and agent expectations can all be edited, and hashing the content would make every edit a new identity. Dashboards charting a scenario's success rate over time need a stable key.
What
scenarios.yamlnow requires anidon the file and on every scenario. Loading rejects missing or duplicate ids.--yesinserts without asking; non-interactive without--yeserrors with instructions.ScenarioGroup/Scenariowhen creating the run. Run-level identity already exists asSimulationRun.id.Example
🤖 Generated with Claude Code