Skip to content

fix: match repo urls case-insensitively when linking packages for impact (IN-1420) #4823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanagmaia merged 9 commits into from
Sep 30, 2026
Merged

fix: match repo urls case-insensitively when linking packages for impact (IN-1420) #4823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
12cc15f
fix: match repo urls case-insensitively when linking packages for imp…
joanagmaia Sep 29, 2026
b2e8b05
fix: limit case-insensitive repo url match to github and gitlab (IN-1…
joanagmaia Sep 29, 2026
54366f4
fix: normalize host casing and tb fmt joins in impact pipes (IN-1420)
joanagmaia Sep 29, 2026
61e2388
fix: lowercase both sides of github and gitlab repo url join (IN-1420)
joanagmaia Sep 29, 2026
61f5f81
fix: gate repo url case folding by url domain on both join sides (IN-…
joanagmaia Sep 29, 2026
b2d9f0c
fix: exclude soft-deleted repositories from impact breakdown join (IN…
joanagmaia Sep 29, 2026
0486996
Merge branch 'main' into fix/IN-1420-impact-case-insensitive-repo-url
joanagmaia Sep 30, 2026
b4bb148
fix: dedupe project packages before summing downloads in impact break…
joanagmaia Sep 30, 2026
7ede3d0
Merge branch 'main' into fix/IN-1420-impact-case-insensitive-repo-url
joanagmaia Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion services/libs/tinybird/pipes/health_score_v2_impact.pipe
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ SQL >
(
SELECT DISTINCT url FROM repositories FINAL WHERE deletedAt IS NULL AND excluded = false
) AS base
INNER JOIN repos r ON r.url = base.url
INNER JOIN
repos r
ON if(lower(domain(r.url)) IN ('github.com', 'gitlab.com'), lower(r.url), r.url)
= if(lower(domain(base.url)) IN ('github.com', 'gitlab.com'), lower(base.url), base.url)
INNER JOIN packageRepos pr ON pr.repoId = r.id
INNER JOIN ossPackages_enriched_ds pk ON pk.id = pr.packageId
GROUP BY base.url
Expand Down
35 changes: 22 additions & 13 deletions services/libs/tinybird/pipes/project_insights_impact_breakdown_copy.pipe
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,24 +80,33 @@ DESCRIPTION >

SQL >
SELECT
ip.id AS projectId,
ip.slug AS slug,
ip.name AS name,
project_packages.projectId AS projectId,
project_packages.slug AS slug,
project_packages.name AS name,
max(pk.dependentCount) AS directDependents,
max(pk.transitiveDependentCount) AS transitiveDependents,
sum(pk.downloadsLast30d) AS downloads,
max(toFloat64OrNull(pk.centralityScore)) AS centrality,
max(toFloat64OrNull(pk.sonatypePopularityScore)) AS sonatypePopularityScore
FROM insightsProjects ip FINAL
LEFT JOIN
repositories rep FINAL
ON rep.insightsProjectId = ip.id
AND rep.enabled = true
AND rep.excluded = false
LEFT JOIN repos r ON r.url = rep.url
LEFT JOIN packageRepos pr ON pr.repoId = r.id
LEFT JOIN ossPackages_enriched_ds pk ON pk.id = pr.packageId
GROUP BY ip.id, ip.slug, ip.name
FROM
(
SELECT DISTINCT
ip.id AS projectId, ip.slug AS slug, ip.name AS name, pr.packageId AS packageId
FROM insightsProjects ip FINAL
LEFT JOIN
repositories rep FINAL
ON rep.insightsProjectId = ip.id
AND rep.enabled = true
AND rep.excluded = false
AND rep.deletedAt IS NULL
LEFT JOIN
repos r
ON if(lower(domain(r.url)) IN ('github.com', 'gitlab.com'), lower(r.url), r.url)
= if(lower(domain(rep.url)) IN ('github.com', 'gitlab.com'), lower(rep.url), rep.url)
LEFT JOIN packageRepos pr ON pr.repoId = r.id
) AS project_packages
LEFT JOIN ossPackages_enriched_ds pk ON pk.id = project_packages.packageId
GROUP BY project_packages.projectId, project_packages.slug, project_packages.name

NODE project_impact_ranked
DESCRIPTION >
Expand Down
Loading