Repository navigation
fix: match repo urls case-insensitively when linking packages for impact (IN-1420) - #4823
Conversation
…act (IN-1420) Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
PR SummaryMedium Risk Overview
The project impact breakdown pipe also filters out deleted repos ( Reviewed by Cursor Bugbot for commit 7ede3d0. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unconditional lowercasing can incorrectly merge distinct repositories on case-sensitive hosts.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Updates Tinybird impact pipelines to match repository URLs case-insensitively when linking packages.
Changes:
- Applies lowercase URL matching to project and health-score impact calculations.
| File | Description |
|---|---|
project_insights_impact_breakdown_copy.pipe |
Makes package-impact URL matching case-insensitive. |
health_score_v2_impact.pipe |
Makes health-score package linking case-insensitive. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…420) Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b2e8b05. Configure here.
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
gaspergrom
left a comment
There was a problem hiding this comment.
LGTM. I checked both join sites against the packageRepos path. The GROUP BY with max() keeps the score stable even if two rows match, and the host restriction keeps other hosts on exact matching. health_score_v2_security, lifecycle and development still join repos on the exact URL, so a follow-up there would keep the scores consistent. lower(domain(...)) would also cover uppercase hosts.
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
…1420) Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
…-1420) Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The host-scoped normalization and deletion filter address the identified correctness issues without changing matching semantics for other hosts.
Review effort: Balanced
Findings: None
Resolved since last review (1)
…down (IN-1420) Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>



Summary
reposon an exact, case-sensitive URL, so projects whose repo URL differs only by casing (e.g.BerriAI/litellm) got no packages and no impact data.project_insights_impact_breakdown_copy.pipeandhealth_score_v2_impact.pipenow join onlower(url).Impact
berriai-litellmgoes from NULL to 2,330 direct dependents / impact 40.6;k8sis unchanged.Jira: https://linuxfoundation.atlassian.net/browse/IN-1420