Repository navigation
LCORE-4710: Implement registry initialization #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,6 +86,8 @@ dependencies = [ | |
| # Used for Pydantic AI | ||
| "pydantic-ai==2.38.0", | ||
| "pydantic-ai-skills>=0.11.0,<2.0.0", | ||
| # Used by the sentence-transformers inference provider (embedding / rerank) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] scope-bundling The PR promotes Suggested fix: Document in the PR description why |
||
| "sentence-transformers>=5.6.0", | ||
| # Used for OpenTelemetry instrumentation | ||
| "opentelemetry-distro>=0.49b0", | ||
| "opentelemetry-exporter-otlp>=1.34.1", | ||
|
|
@@ -183,8 +185,6 @@ ogxlibdev = [ | |
| "langdetect>=1.0.9", | ||
| "emoji>=2.1.0", | ||
| "nltk>=3.8.1", | ||
| # API inference: inline::sentence-transformers | ||
| "sentence-transformers>=5.6.0", | ||
| # API vector_io: inline::faiss, inline::sqlite-vec, remote::pgvector | ||
| "faiss-cpu>=1.11.0", | ||
| "chardet>=5.2.0", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import Literal, Optional, overload | ||
| from typing import Literal, Optional, cast, overload | ||
|
|
||
| from pydantic_ai.embeddings import EmbeddingModel | ||
| from sentence_transformers import CrossEncoder | ||
|
|
@@ -69,4 +69,4 @@ def put( | |
| if isinstance(model, CrossEncoder): | ||
| self._rerankers[provider_model_id] = model | ||
| else: | ||
| self._embeddings[provider_model_id] = model | ||
| self._embeddings[provider_model_id] = cast(EmbeddingModel, model) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consequence of ST being added as a main dependency
asimurka marked this conversation as resolved.
Resolved
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need ST to be main dependency