You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wire inference provider registry initialization into FastAPI lifespan so configured providers are built and their catalogs loaded before the service serves traffic.
Integration tests for config will be supplied in another PR.
If it is a core feature, I have added thorough tests.
Testing
Unit
uv run pytest tests/unit/app/test_main_startup.py -q
test_lifespan_initializes_inference_registry — OpenAI provider with skip_model_discovery=True; after lifespan startup, registry lists the provider and catalog model chat.
test_lifespan_propagates_model_discovery_error — discovery enabled; AsyncModels.list raises APIConnectionError; lifespan raises ModelDiscoveryError and leaves the registry empty.
Summary by CodeRabbit
New Features
Configured inference providers are initialized as the application starts, making their models available for requests.
Bug Fixes
Provider discovery failures are surfaced during startup, and failed initialization leaves the provider registry empty.
Chores
Startup logs now show which inference providers were registered.
The application lifespan now initializes configured inference providers before OGX client setup. The registry logs the registered provider count and IDs. Unit tests cover successful registration and model discovery failure.
Changes
Inference provider startup
Layer / File(s)
Summary
Lifespan initialization and validation src/app/main.py, src/providers/inference/registry.py, tests/unit/app/test_main_startup.py, tests/unit/app/README.md
The lifespan initializes the registry with inference configuration. The registry logs provider count and IDs. Tests cover provider registration and discovery failure. The README lists the new tests.
sequenceDiagram
participant Lifespan as FastAPI lifespan
participant Registry as ProviderRegistry
participant OpenAI as OpenAI provider
Lifespan->>Registry: initialize(configuration.inference)
opt Model discovery enabled
Registry->>OpenAI: list models
OpenAI-->>Registry: models or ModelDiscoveryError
end
Lifecycle re-entry can retain removed providers and leave clients open, and the startup log can be missing. The risk is bounded but warrants follow-up.
Pre-merge checks: 7
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: implementing inference provider registry initialization.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity
No blocking performance regression found. The pull request adds one startup call to ProviderRegistry.initialize; that method performs a linear pass over configured providers, with no nested per-mode…
Security And Secret Handling
No security violation was introduced. The PR adds startup initialization and logs only provider count and local provider IDs in src/providers/inference/registry.py:67-72; it does not log API keys or…
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)
Full details: Performance And Algorithmic Complexity
Explanation
No blocking performance regression found. The pull request adds one startup call to ProviderRegistry.initialize; that method performs a linear pass over configured providers, with no nested per-model queries, unbounded cache, or new list endpoint. The added registry log performs one linear list copy and does not materially affect runtime. Provider discovery uses provider-level listing calls as part of the required startup initialization, not an introduced list-then-query-per-item pattern.
Full details: Security And Secret Handling
Explanation
No security violation was introduced. The PR adds startup initialization and logs only provider count and local provider IDs in src/providers/inference/registry.py:67-72; it does not log API keys or tokens. src/app/main.py:101 adds no endpoint or request handling, so it introduces no missing auth/authz, injection path, or response leak. The API keys in tests/unit/app/test_main_startup.py:73 are dummy test values. No Kubernetes Secret or RH secret manifest changes are present.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Simplify code
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 4cae323 and 28d93dd.
Files selected for processing: 4
src/app/main.py
src/providers/inference/registry.py
tests/unit/app/README.md
tests/unit/app/test_main_startup.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Recent review details
Context from checks skipped due to timeout: 27
GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
Source excerpt: **Required**: Use pytest for all unit and integration tests **Forbidden**: Do not use unittest - pytest is the standard for this project Source excerpt: **Coverage**: Unit tests require 60% coverage, integration 10%
CodeRabbit inference engine (CLAUDE.md)
Files:
tests/unit/app/README.md
tests/unit/app/test_main_startup.py
Source excerpt: **Required**: Use pytest for all unit and integration tests Source excerpt: **Forbidden**: Do not use unittest - pytest is the standard for this project Source excerpt: **Coverage**: Unit tests require 60% coverage, integrat...
CodeRabbit inference engine (AGENTS.md)
Files:
tests/unit/app/README.md
tests/unit/app/test_main_startup.py
Source excerpt: **Fixtures**: Use `conftest.py` for shared fixtures Source excerpt: **Mocking**: `pytest-mock` for AsyncMock objects Source excerpt: **Async tests**: Use marker `pytest.mark.asyncio`
CodeRabbit inference engine (CLAUDE.md)
Files:
tests/unit/app/README.md
tests/unit/app/test_main_startup.py
Learnings: 6
Learning: 2026-10-31T11:32:30.158Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T11:32:30.158Z
Learning: Source excerpt:
# Lightspeed Core Stack Development Guide
## Code Architecture & Patterns
### Coding Standards
#### Module Standards
- All modules start with descriptive docstrings explaining purpose
- Use `logger = get_logger(__name__)` from `log.py` for module logging
- Package `__init__.py` files contain brief package descriptions
- Central `constants.py` for shared constants with descriptive comments
- Type aliases defined at module level for clarity
- Use Final[type] as type hint for all constants
Applied to files:
src/providers/inference/registry.py
Learning: 2026-10-31T11:32:30.158Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T11:32:30.158Z
Learning: Applies to tests/unit/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Unit Tests (pytest)
- **Async tests**: Use marker `pytest.mark.asyncio`
Applied to files:
tests/unit/app/test_main_startup.py
Learning: 2026-10-31T11:32:13.138Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-31T11:32:13.138Z
Learning: Applies to tests/unit/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Unit Tests (pytest)
- **Mocking**: `pytest-mock` for AsyncMock objects
Applied to files:
tests/unit/app/test_main_startup.py
Learning: 2026-10-31T11:32:13.138Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-31T11:32:13.138Z
Learning: Applies to tests/{unit,integration}/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Testing Framework Requirements
- **Forbidden**: Do not use unittest - pytest is the standard for this project
Applied to files:
tests/unit/app/test_main_startup.py
Learning: 2026-10-31T11:32:30.158Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T11:32:30.158Z
Learning: Applies to tests/{unit,integration}/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Testing Framework Requirements
- **Required**: Use pytest for all unit and integration tests
- **Forbidden**: Do not use unittest - pytest is the standard for this project
Applied to files:
tests/unit/app/test_main_startup.py
Learning: 2026-10-31T11:32:13.138Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-31T11:32:13.138Z
Learning: Applies to tests/{unit,integration}/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Testing Framework Requirements
- **Required**: Use pytest for all unit and integration tests
14 files with 264 lines across inference provider modules. Low test ratio is the only elevated signal. Moderate churn on pyproject.toml. Weighted composite 2.
[scope-bundling]pyproject.toml:89 — The PR promotes sentence-transformers (which transitively pulls in PyTorch/torch) from the ogxlibdev dev dependency group to a main runtime dependency. This is a significant deployment-impacting change (container image size, startup time, memory footprint) that is bundled with the registry wiring work without separate justification in the PR description.
Remediation: Document in the PR description why sentence-transformers must become a main dependency, or split the dependency promotion into a separate PR with its own rationale and impact analysis.
Low
[edge-case]src/providers/inference/registry.py:62 — ProviderRegistry.initialize() has no cleanup on partial failure. If the Nth provider fails during await provider.initialize(), previously-initialized providers remain in _providers, leaving the singleton in a half-initialized state. Currently benign in production (service aborts on failure), but the contract is fragile.
Remediation: Clear self._providers at the top of initialize() so the method is idempotent.
[missing-test]tests/unit/app/test_main_startup.py:170 — No test covers multi-provider partial-failure or empty-providers configuration paths.
Remediation: Add tests for multi-provider partial failure and empty providers list.
[scope-creep]src/providers/inference/sentence_transformers/model_cache.py:72 — The cast(EmbeddingModel, model) change is an unrelated type-narrowing fix not mentioned in the PR description.
[stale-doc]docs/devel_doc/providers.md:37 — The sentence-transformers provider row lists sentence-transformers --no-deps as a separate pip dependency, but this PR moves it to main dependencies.
Remediation: Update the Pip Dependencies column to indicate the package is now bundled.
Labels: New feature PR adding inference provider registry initialization.
The reason will be displayed to describe this comment to others. Learn more.
Note: The following review comments could not be posted on the diff (GitHub returned 422) and are included here instead:
src/providers/inference/registry.py (file-level): Line 62 · [low] edge-case
ProviderRegistry.initialize() has no cleanup on partial failure. If the Nth provider fails during await provider.initialize(), previously-initialized providers remain in _providers, leaving the singleton in a half-initialized state. In production the service aborts on failure so this is currently benign, but the contract is fragile.
Suggested fix: Clear self._providers at the top of initialize() (e.g., self._providers.clear()) so the method is idempotent and any retry starts from a clean slate.
The reason will be displayed to describe this comment to others. Learn more.
[medium] scope-bundling
The PR promotes sentence-transformers (which transitively pulls in PyTorch/torch) from the ogxlibdev dev dependency group to a main runtime dependency. This is a significant deployment-impacting change (container image size, startup time, memory footprint) that is bundled with the registry wiring work without separate justification or discussion in the PR description.
Suggested fix: Document in the PR description why sentence-transformers must become a main dependency, or split the dependency promotion into a separate PR with its own rationale and impact analysis.
Review agent should recognize dependency-coupled companion changes before recommending PR splits fullsend-ai/fullsend#2394: The review agent flagged cast(EmbeddingModel, model) in model_cache.py as scope-creep — an "unrelated mypy type-narrowing fix." The author correctly explained it was a direct consequence of moving sentence-transformers from runtime import to TYPE_CHECKING: the type checker can no longer infer the type narrowing from the isinstance check above, requiring an explicit cast(). This is a dependency-coupled companion change, not scope creep.
The human reviewer approved with "LGTM" and no inline comments. Per the autonomy-readiness methodology, the delta between agent and human review is inconclusive — silent approval means the human found nothing to flag, but we cannot infer that the agent matched or exceeded human review from this single PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
Description
Wire inference provider registry initialization into FastAPI lifespan so configured providers are built and their catalogs loaded before the service serves traffic.
Integration tests for config will be supplied in another PR.
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Unit
test_lifespan_initializes_inference_registry— OpenAI provider withskip_model_discovery=True; after lifespan startup, registry lists the provider and catalog modelchat.test_lifespan_propagates_model_discovery_error— discovery enabled;AsyncModels.listraisesAPIConnectionError; lifespan raisesModelDiscoveryErrorand leaves the registry empty.Summary by CodeRabbit