Skip to content

feat(payment-instructions): allow USDT as an Ethereum wallet assetType - #767

Merged
jklein24 merged 1 commit into
mainfrom
07-29-ethereum-wallet-usdt-asset-type
Jul 30, 2026
Merged

feat(payment-instructions): allow USDT as an Ethereum wallet assetType#767
jklein24 merged 1 commit into
mainfrom
07-29-ethereum-wallet-usdt-asset-type

Conversation

@jklein24

@jklein24 jklein24 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Allows USDT as an assetType on the Ethereum wallet payment-instruction schema, so an internal account denominated in USDT can return Ethereum L1 funding instructions. Previously PaymentEthereumWalletInfo.assetType accepted only USDC, which meant a USDT balance had no way to express an Ethereum L1 deposit address.

USDT is already a valid assetType on the Tron wallet schema; this brings Ethereum in line.

Changes

  • openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml — add USDT to the assetType enum
  • openapi.yaml, mintlify/openapi.yaml — rebundled via make build

No change to EthereumWalletExternalAccountInfo: external accounts carry no assetType, and their currency comes from the request body, which already accepts USDT.

Test plan

  • make lint-openapi — 0 errors (the 136 warnings / 494 infos are pre-existing repo-wide schema-properties-have-{examples,descriptions} noise; none reference this schema)
  • oasdiff breaking <main> <head> --format singleline --fail-on ERR — 0 errors, 37 warnings, all response-property-enum-value-added for the operations that return payment instructions. Adding a value to a response enum is non-breaking, so info.version is intentionally unchanged.

Reply with a comment (e.g. LGTM) to approve — emoji reactions don't notify me here.

Requested by @jklein24

Original PR: #766

@ls-bolt ls-bolt Bot added the bolt label Jul 29, 2026
@ls-bolt ls-bolt Bot mentioned this pull request Jul 29, 2026
Closed
@akanter Graphite App

akanter commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jklein24
jklein24 marked this pull request as ready for review July 29, 2026 23:42
@jklein24
jklein24 enabled auto-merge (squash) July 29, 2026 23:42
@github-actions

github-actions Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

go

chore(internal): regenerate SDK with no functional changes

kotlin

chore(internal): regenerate SDK with no functional changes

openapi

feat(api): add USDT to asset type enum

php

chore(internal): regenerate SDK with no functional changes

python

chore(internal): regenerate SDK with no functional changes

ruby

chore(internal): regenerate SDK with no functional changes

typescript

chore(internal): regenerate SDK with no functional changes
⚠️ grid-openapi studio · code

Your SDK build had at least one "warning" diagnostic.
generate ⚠️

✅ grid-ruby studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ⏭️ → lint ✅ → test ✅

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅ → build ⏭️ → lint ❗ → test ❗

go get github.com/stainless-sdks/grid-go@55b8dcd717c7e0f4a78da24fbb2be7838888bca6
⚠️ grid-kotlin studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️ → build ⏭️ → lint ⏭️ → test ❗

⚠️ grid-python studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ✅ → build ⏭️ → lint ⏭️ → test ❗

✅ grid-typescript studio · conflict

Your SDK build had at least one note diagnostic.

✅ grid-php studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → lint ✅ → test ✅

⚠️ grid-cli studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️ → build ⏭️ → lint ⏭️ → test ❗

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-30 01:23:51 UTC

@jklein24
jklein24 requested a review from shreyav July 29, 2026 23:42
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

     ⚡  \m/  ☠  \m/  ⚡
      ╲╱╲╱╲╱╲╱╲╱
     ETHEREUM THUNDERS,
        USDT RISES!

Unleash the stablecoin riffs upon Ethereum L1.

  • Adds USDT to the Ethereum wallet payment-instruction assetType enum.
  • Regenerates both committed OpenAPI bundles with the expanded response schema.

Confidence Score: 5/5

The PR appears safe to merge, with the source schema and both generated bundles consistently allowing USDT for Ethereum wallet payment instructions.

The enum expansion is consistent with sibling chain-specific wallet schemas, and the generated OpenAPI artifacts match the canonical source change without introducing a security or behavioral defect.

Important Files Changed
Filename Overview
openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml Expands the canonical Ethereum wallet payment-instruction schema to permit both USDC and USDT.
openapi.yaml Keeps the root generated OpenAPI bundle synchronized with the source schema.
mintlify/openapi.yaml Keeps the generated Mintlify OpenAPI bundle synchronized with the source schema.

Reviews (1): Last reviewed commit: "feat(payment-instructions): allow USDT a..." | Re-trigger Greptile

@jklein24
jklein24 merged commit 63b759d into main Jul 30, 2026
18 checks passed
@jklein24
jklein24 deleted the 07-29-ethereum-wallet-usdt-asset-type branch July 30, 2026 01:18
@claude claude Bot mentioned this pull request Jul 30, 2026
Merged
3 tasks
jklein24 pushed a commit that referenced this pull request Jul 30, 2026
@claude @github-actions @claude
docs: sync Grid Visualizer and Kotlin sample with Plasma/USDT schema …
8da9f4d 
…changes (#771)

## Summary
- Add PLASMA_WALLET account type to Grid Visualizer data
- Add ETHEREUM_WALLET and PLASMA_WALLET networks for USDT in Grid
Visualizer
- Add PLASMA_WALLET handler to Kotlin sample external account creation

## Context
Recent OpenAPI schema changes added PLASMA_WALLET support and USDT on
Ethereum. This PR syncs the documentation artifacts (Grid Visualizer,
Kotlin sample) with these changes.

Related commits:
- 927ce42 Add Plasma (PLASMA_WALLET) to Grid public API schema (#724)
- 63b759d feat(payment-instructions): allow USDT as an Ethereum wallet
assetType (#767)

## Other schema changes reviewed (no doc updates needed)
The following recent schema changes were reviewed and require no
documentation updates:
- SCA_SESSION_REQUIRED (409) and ACCOUNT_LOCKED (423) on quote authorize
- already documented in OpenAPI spec
- SCA_NOT_COMPLETED outgoing transaction failure reason - already
documented in OpenAPI spec
- Error400.details.errors[] array for field validation - already
documented in OpenAPI spec

Mintlify docs already include PLASMA_WALLET in
`snippets/internal-accounts.mdx`.

## Test plan
- [ ] Grid Visualizer TypeScript compiles without errors
- [ ] Kotlin sample compiles without errors
- [ ] Verify PLASMA_WALLET appears in Grid Visualizer crypto selection
for USDT

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyav shreyav shreyav approved these changes

Assignees

No one assigned

Labels

bolt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jklein24 @akanter @shreyav