feat(payment-instructions): allow USDT as an Ethereum wallet assetType - #766
feat(payment-instructions): allow USDT as an Ethereum wallet assetType#766ls-bolt[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-cli studio · code · diff
✅ grid-php studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-python studio · code · diff
✅ grid-kotlin studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
|
Do we also need to update any docs in mintlify or anything for this? |
Greptile SummaryThis PR expands Ethereum wallet payment instructions to represent USDT funding.
Confidence Score: 5/5The PR appears safe to merge with the source schema and generated bundles synchronized. The additive enum change is represented consistently across all three artifacts, and the existing schema composition permits the new Ethereum wallet asset without introducing a contradictory discriminator or structural contract.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml | Adds USDT to the Ethereum wallet asset enum, consistent with existing multi-asset wallet schemas. |
| openapi.yaml | Correctly reflects the source-schema change in the generated root bundle. |
| mintlify/openapi.yaml | Correctly mirrors the regenerated root bundle for local documentation use. |
Reviews (1): Last reviewed commit: "feat(payment-instructions): allow USDT a..." | Re-trigger Greptile
|
Checked — nothing else to update, and here's what I verified rather than assumed:
That first one is worth a look independently of this PR — it says cross-currency funding is USDC/BTC only, which hasn't been true since USDT-on-Tron shipped. Happy to fix it here or leave it out of scope; it's a docs accuracy issue that predates this change, not something adding the enum value breaks. |
#767) ## Summary Allows `USDT` as an `assetType` on the Ethereum wallet payment-instruction schema, so an internal account denominated in USDT can return Ethereum L1 funding instructions. Previously `PaymentEthereumWalletInfo.assetType` accepted only `USDC`, which meant a USDT balance had no way to express an Ethereum L1 deposit address. USDT is already a valid `assetType` on the Tron wallet schema; this brings Ethereum in line. ## Changes - `openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml` — add `USDT` to the `assetType` enum - `openapi.yaml`, `mintlify/openapi.yaml` — rebundled via `make build` No change to `EthereumWalletExternalAccountInfo`: external accounts carry no `assetType`, and their currency comes from the request body, which already accepts USDT. ## Test plan - `make lint-openapi` — 0 errors (the 136 warnings / 494 infos are pre-existing repo-wide `schema-properties-have-{examples,descriptions}` noise; none reference this schema) - `oasdiff breaking <main> <head> --format singleline --fail-on ERR` — **0 errors, 37 warnings**, all `response-property-enum-value-added` for the operations that return payment instructions. Adding a value to a response enum is non-breaking, so `info.version` is intentionally unchanged. Reply with a comment (e.g. LGTM) to approve — emoji reactions don't notify me here. Requested by @jklein24 Original PR: #766

Summary
Allows
USDTas anassetTypeon the Ethereum wallet payment-instruction schema, so an internal account denominated in USDT can return Ethereum L1 funding instructions. PreviouslyPaymentEthereumWalletInfo.assetTypeaccepted onlyUSDC, which meant a USDT balance had no way to express an Ethereum L1 deposit address.USDT is already a valid
assetTypeon the Tron wallet schema; this brings Ethereum in line.Changes
openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml— addUSDTto theassetTypeenumopenapi.yaml,mintlify/openapi.yaml— rebundled viamake buildNo change to
EthereumWalletExternalAccountInfo: external accounts carry noassetType, and their currency comes from the request body, which already accepts USDT.Test plan
make lint-openapi— 0 errors (the 136 warnings / 494 infos are pre-existing repo-wideschema-properties-have-{examples,descriptions}noise; none reference this schema)oasdiff breaking <main> <head> --format singleline --fail-on ERR— 0 errors, 37 warnings, allresponse-property-enum-value-addedfor the operations that return payment instructions. Adding a value to a response enum is non-breaking, soinfo.versionis intentionally unchanged.Reply with a comment (e.g. LGTM) to approve — emoji reactions don't notify me here.
Requested by @jklein24