fix(protocol): drop reachabilityChanged from enabled incoming calls - #29683
Merged
Merged
Conversation
The JS side stopped handling it in #29675, but only the generated index.tsx was edited, so CI's regen put the union member back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's codegen check fails: regenerating the rpc types adds
reachability.reachabilityChangedback to the incoming action union inshared/constants/rpc/index.tsx.The JS side stopped handling that notification in #29675. That change edited the generated file by hand but left the entry in
protocol/bin/enabled-calls.json, the file the generator reads, so every regen puts it back. This removes the entry. Regenerating now matches the committed files, andyarn tscis clean.