Skip to content

fix(protocol): regen rpc-gen.tsx after dropping reachabilityChanged - #29684

Merged
chrisnojima merged 3 commits into
masterfrom
nojima/HOTPOT-fix-ci-2
Sep 24, 2026
Merged

chrisnojima merged 3 commits into
masterfrom
nojima/HOTPOT-fix-ci-2

Conversation

@chrisnojima

Copy link
Copy Markdown
Contributor

CI's regen check was failing: #29683 removed `reachabilityChanged` from `protocol/bin/enabled-calls.json` but didn't regenerate `shared/constants/rpc/rpc-gen.tsx`, so `gen_mocks.sh` produced a diff.

  • Regenerated `rpc-gen.tsx` from the protocol generator (drops the `reachabilityChanged` entry from `MessageTypes`/`IncomingMethod`, lists it as not enabled).
  • CLAUDE.md: rerun the generator after editing `protocol/avdl/` or `enabled-calls.json`, and never hand-edit generated code.

@chrisnojima
chrisnojima merged commit 558c60e into master Sep 24, 2026
1 check was pending
@chrisnojima
chrisnojima deleted the nojima/HOTPOT-fix-ci-2 branch September 24, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant