Add thefill_value parameter to GeocodeCov CPU module - #352
Open
gshiroma wants to merge 14 commits into
Open
Conversation
…issing radar samples
gshiroma
changed the title
fill_value Parameter to GeocodeCov CPU modulefill_value parameter to GeocodeCov CPU module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
fill_valueparameter to theGeocodeCovCPU module. It is inspired by #337 and sets the fill value of the layover/shadow mask layer in the Static Layers (STATIC) product to255, instead of the default value of0. Details about the issue and the discussion can be found in that PR.The C++ and Python interfaces have been updated with the new parameter. The two CPU geocoding algorithms, interpolation and area projection, have also been updated to account for the new parameter. For the interpolation algorithm, the array is first filled with
fill_valuebefore interpolation occurs. In contrast, for the area projection algorithm,fill_valueis applied after multilooking. This is necessary because the area projection algorithm accumulates averaged values (multilooked backscatter), and applyingfill_valuebefore data accumulation could cause it to be interpreted as a valid value.