[Newton] Pin use_coord_layout_targets = False - #7449
Conversation
…o Newton 1.6 Joint dofs require a separate fix, as they don't convert to/from quaternions
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR explicitly pins Newton’s process-global joint-target layout to the existing DOF-based behavior in both relevant package import paths and adds a focused floating-base regression test that distinguishes coordinate and DOF layouts.
- Design and architecture: The import-time assignment runs before model construction initiated through either integration path. Duplicating the pin across
isaaclab.actuators.newtonandisaaclab_newtonis a deliberate compatibility measure, with the non-blocking maintenance tradeoff that both sites must be removed together during migration to coordinate-layout targets. - API: No Isaac Lab public symbols, signatures, exports, or return types change. The pin intentionally preserves the existing target-array compatibility contract across Newton’s upcoming default change, and
.skipfragments cover both touched packages. - Implementation: Both assignments occur before the packages import model-related integration modules. The regression test constructs an articulation containing a free joint, confirms coordinate and DOF counts differ, and verifies
joint_target_qremains DOF-sized. A residual maintenance risk is that Newton may eventually remove the deprecated flag, at which point the test remains important for detecting lost behavior.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryPins Newton’s joint-position target storage to the existing per-DOF layout before model construction, preserving compatibility when Newton 1.6 changes its default.
Confidence Score: 5/5The PR appears safe to merge, with the compatibility pin applied before supported Isaac Lab model-building paths and a focused regression test covering the intended layout. The changed initializers preserve the per-DOF target layout expected by actuator consumers, and the reviewed import chains apply the pin before Newton models are constructed. Important Files Changed
Reviews (1): Last reviewed commit: "[Newton] Pin `use_coord_layout_targets =..." | Re-trigger Greptile |
Description
Pin
use_coord_layout_targets = Falseto enable migration to Newton 1.6Newton added a config
use_coord_layout_targetsin newton-physics/newton/#3617. The default will flip in Newton 1.6, so this change preserves the existing behavior.Type of change
Release backport
developScreenshots
Please attach before and after screenshots of the change if applicable.
Checklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there