Remove OVPhysX presets from deformable lift tasks - #7447
Conversation
Greptile SummaryThe PR removes OVPhysX support from the four Franka cloth and soft-deformable lift tasks while retaining Isaac Sim PhysX, automatic PhysX selection, and OVRTX rendering.
Confidence Score: 5/5The PR appears safe to merge, with the unsupported backend removed consistently from task configuration, preset resolution, browser metadata, tests, and release documentation. The affected task variants now reject OVPhysX during preset resolution, retain valid Isaac Sim PhysX and automatic selection paths, and have synchronized regression coverage and browser metadata. Important Files Changed
Reviews (1): Last reviewed commit: "Remove OVPhysX deformable lift presets" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The patch consistently removes OVPhysX availability from the four deformable Franka lift tasks while retaining Isaac Sim PhysX, automatic PhysX selection, Newton presets, and OVRTX rendering. Registry-facing documentation and focused preset coverage were updated alongside the configuration changes.
- Design and architecture: The physics, deformable, scene, event, and curriculum preset paths were traced across the cloth and soft configurations. OVPhysX-specific definitions and references are removed consistently, while
physxremains backed solely byisaacsim_physxand existing defaults remain unchanged. - API: The changed compatibility surface is explicit:
physics=ovphysxandpresets=ovphysxcease to be available for the four task IDs. The changelog marks this as breaking and directs users tophysics=isaacsim_physx; the environment browser reflects the same availability while preservingovrtx. The lack of a deprecation period remains a policy tradeoff for maintainers given the documented incorrect OVPhysX behavior. - Implementation: The browser rows match the changed task presets, obsolete
isaaclab_ovimports are removed, and the regression extends the closest existing preset test across all four task IDs. The existing registry-wide auto-selector assertion should remain valid because the omittedPhysxAutoCfg.ovphysxvalue and absent preset both resolve toNone.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
da10fc9 to
d15e481
Compare
OVPhysX does not inherit the deformable-root physics-material binding onto the child simulation mesh, so the cloth and soft Franka lift tasks simulate with incorrect material behavior. Remove the OVPhysX physics, deformable, scene, event, and curriculum presets from these tasks and their camera variants, keeping Isaac Sim PhysX and the automatic PhysX selector. The events and curriculum preset wrappers existed solely to give OVPhysX a variant with gravity randomization disabled, so they collapse to the plain configs once that branch is gone. Tracked in NVIDIA-Omniverse/PhysX#504.
d15e481 to
0261d80
Compare
Summary
OVPhysX currently does not inherit deformable-root physics-material bindings onto child simulation meshes, causing these tasks to simulate with incorrect material behavior. This is tracked in NVIDIA-Omniverse/PhysX#504.
Affected tasks:
Isaac-Lift-Cloth-Franka,Isaac-Lift-Cloth-Franka-Camera,Isaac-Lift-Soft-Franka,Isaac-Lift-Soft-Franka-Camera. Theovrtxrenderer is retained, since it is a renderer rather than the removed physics backend.Breaking change
physics=ovphysxandpresets=ovphysxare no longer available for these four tasks. Usephysics=isaacsim_physxinstead.Testing
uv run isaaclab -f: all hooks passed