Skip to content

chore(lint): fix lint warnings and fail lint on warnings #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandyscarney wants to merge 1 commit into from
Open

chore(lint): fix lint warnings and fail lint on warnings #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,5 @@ export default defineConfig([
languageOptions: {
globals: globals.browser,
},
rules: {
// Ionic's base level; `recommended` makes it an error, which is meant for libraries.
'@typescript-eslint/explicit-module-boundary-types': 'warn',
},
},
]);
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"test.unit": "vitest",
"lint": "npm run eslint && npm run prettier -- --check",
"lint:fix": "npm run eslint -- --fix && npm run prettier -- --write",
"eslint": "eslint",
"eslint": "eslint --max-warnings 0",
"prettier": "prettier \"**/*.{ts,tsx}\""
},
"dependencies": {
Expand Down
6 changes: 5 additions & 1 deletion src/hooks/usePhotoGallery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ import { isPlatform } from '@ionic/react';
import { useState, useEffect } from 'react';

const PHOTO_STORAGE = 'photos';
export function usePhotoGallery() {
export function usePhotoGallery(): {
deletePhoto: (photo: UserPhoto) => Promise<void>;
photos: UserPhoto[];
takePhoto: () => Promise<void>;
} {
const [photos, setPhotos] = useState<UserPhoto[]>([]);

useEffect(() => {
Expand Down
Loading