Repository navigation
chore(lint): fix lint warnings and fail lint on warnings - #73
Open
brandyscarney wants to merge 1 commit into
Open
brandyscarney wants to merge 1 commit into
brandyscarney wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
chore/fix-lint-warnings
branch
from
October 23, 2026 19:16
9c252e7 to
1d39601
Compare
This was referenced Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Fixes the lint warnings left by the previous PR and makes lint fail on any warning.
New Behavior
npm run lint, and the Lint job in CI, fail on any ESLint warning, not just errors.@typescript-eslint/explicit-module-boundary-typesis an error again (the@ionic/eslint-config/recommendedlevel), so exported functions and public methods need explicit return types.Changes
usePhotoGalleryhook.warnoverride forexplicit-module-boundary-typesfrom the ESLint config.--max-warnings 0to theeslintscript.Notes