Skip to content

chore(lint): fix lint warnings and fail lint on warnings - #73

Open
brandyscarney wants to merge 1 commit into
chore/add-lint-workflowfrom
chore/fix-lint-warnings
Open

brandyscarney wants to merge 1 commit into
chore/add-lint-workflowfrom
chore/fix-lint-warnings

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

What This Does

Fixes the lint warnings left by the previous PR and makes lint fail on any warning.

New Behavior

  • npm run lint, and the Lint job in CI, fail on any ESLint warning, not just errors.
  • @typescript-eslint/explicit-module-boundary-types is an error again (the @ionic/eslint-config/recommended level), so exported functions and public methods need explicit return types.

Changes

  • Explicit return types on the usePhotoGallery hook.
  • Removes the warn override for explicit-module-boundary-types from the ESLint config.
  • Adds --max-warnings 0 to the eslint script.

Notes

  • The return types are on code the "Your First App" docs teach. Once this stack merges, a follow-up ionic-docs PR will add the same annotations to the snippets.

@brandyscarney
brandyscarney added this pull request to stack #74 October 23, 2026 16:11
@brandyscarney
brandyscarney requested a review from a team as a code owner October 23, 2026 16:11
@brandyscarney
brandyscarney requested review from thetaPC and removed request for a team October 23, 2026 16:11
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tutorial-photo-gallery-react Ready Ready Preview Oct 23, 2026 7:16pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 1d39601f Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant