Skip to content

fix(android): downsample bitmaps to reduce memory usage #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luatbbg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): downsample bitmaps to reduce memory usage #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions android/src/main/java/com/capacitorjs/plugins/camera/IonCameraFlow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,30 @@ class IonCameraFlow(
callEditURIPhoto(call)
}

private fun decodeSampledBitmap(path: String, maxSize: Int = 2048): android.graphics.Bitmap? {
val options = BitmapFactory.Options().apply {
inJustDecodeBounds = true
}

BitmapFactory.decodeFile(path, options)

var sampleSize = 1
while (
options.outWidth / sampleSize > maxSize ||
options.outHeight / sampleSize > maxSize
) {
sampleSize *= 2
}

return BitmapFactory.decodeFile(
path,
BitmapFactory.Options().apply {
inSampleSize = sampleSize
}
)
}


// ----------------------------------------------------
// Launchers
// ----------------------------------------------------
Expand Down Expand Up @@ -719,7 +743,7 @@ class IonCameraFlow(
private fun handleMediaResult(mediaResult: IONCAMRMediaResult) {
val file = File(mediaResult.uri)
val uri = Uri.fromFile(file)
val bitmap = BitmapFactory.decodeFile(mediaResult.uri)
val bitmap = decodeSampledBitmap(mediaResult.uri)
if (bitmap == null) {
sendError(IONCAMRError.PROCESS_IMAGE_ERROR)
return
Expand Down Expand Up @@ -799,7 +823,7 @@ class IonCameraFlow(
metadata.put("creationDate", it.creationDate)

if (mediaResult.type == IONCAMRMediaType.PICTURE.type) {
val bitmap = BitmapFactory.decodeFile(mediaResult.uri)
val bitmap = decodeSampledBitmap(mediaResult.uri)
if (bitmap == null) {
sendError(IONCAMRError.PROCESS_IMAGE_ERROR)
return
Expand Down
68 changes: 61 additions & 7 deletions android/src/main/java/com/capacitorjs/plugins/camera/LegacyCameraFlow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,64 @@ private void openPhotos(final PluginCall call, boolean multiple) {
}
}


private static final int MAX_BITMAP_SIZE = 2048;

private int calculateInSampleSize(
BitmapFactory.Options options,
int maxSize
) {
int width = options.outWidth;
int height = options.outHeight;
int inSampleSize = 1;

while (width / inSampleSize > maxSize ||
height / inSampleSize > maxSize) {
inSampleSize *= 2;
}

return inSampleSize;
}

private Bitmap decodeSampledBitmapFromFile(String path) {
BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;

BitmapFactory.decodeFile(path, options);

options.inSampleSize =
calculateInSampleSize(options, MAX_BITMAP_SIZE);
options.inJustDecodeBounds = false;

return BitmapFactory.decodeFile(path, options);
}

private Bitmap decodeSampledBitmapFromUri(Uri uri)
throws FileNotFoundException {

BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;

try (InputStream stream =
context.getContentResolver().openInputStream(uri)) {
BitmapFactory.decodeStream(stream, null, options);
} catch (IOException e) {
throw new RuntimeException("Unable to read image", e);
}

options.inSampleSize =
calculateInSampleSize(options, MAX_BITMAP_SIZE);
options.inJustDecodeBounds = false;

try (InputStream stream =
context.getContentResolver().openInputStream(uri)) {
return BitmapFactory.decodeStream(stream, null, options);
} catch (IOException e) {
throw new RuntimeException("Unable to read image", e);
}
}


public void processCameraImage(PluginCall call, ActivityResult result) {
settings = getSettings(call);
if (imageFileSavePath == null) {
Expand All @@ -379,9 +437,8 @@ public void processCameraImage(PluginCall call, ActivityResult result) {
}
// Load the image as a Bitmap
File f = new File(imageFileSavePath);
BitmapFactory.Options bmOptions = new BitmapFactory.Options();
Uri contentUri = Uri.fromFile(f);
Bitmap bitmap = BitmapFactory.decodeFile(imageFileSavePath, bmOptions);
Bitmap bitmap = decodeSampledBitmapFromFile(imageFileSavePath);

if (bitmap == null) {
call.reject(USER_CANCELLED);
Expand Down Expand Up @@ -415,9 +472,7 @@ private void processPickedImage(Uri imageUri, PluginCall call) {
InputStream imageStream = null;

try {
imageStream = context.getContentResolver().openInputStream(imageUri);
Bitmap bitmap = BitmapFactory.decodeStream(imageStream);

Bitmap bitmap = decodeSampledBitmapFromUri(imageUri);
if (bitmap == null) {
call.reject("Unable to process bitmap");
return;
Expand All @@ -443,9 +498,8 @@ private JSObject processPickedImages(Uri imageUri) {
InputStream imageStream = null;
JSObject ret = new JSObject();
try {
imageStream = context.getContentResolver().openInputStream(imageUri);
Bitmap bitmap = BitmapFactory.decodeStream(imageStream);

Bitmap bitmap = decodeSampledBitmapFromUri(imageUri);
if (bitmap == null) {
ret.put("error", "Unable to process bitmap");
return ret;
Expand Down