Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve Android bitmap decoding by introducing bitmap downsampling in IonCameraFlow.kt and LegacyCameraFlow.java.
The changes use BitmapFactory.Options with inJustDecodeBounds and inSampleSize to avoid decoding unnecessarily large bitmaps at full resolution.
Change Type
Rationale / Problems Fixed
Decoding high-resolution camera and gallery images directly into memory can cause excessive memory consumption and increase the risk of OutOfMemoryError.
This change introduces sampled bitmap decoding to reduce peak memory usage during image processing.
It also aims to address the bitmap downsampling performance recommendation reported by Google Play Console.
Tests or Reproductions
Android Gradle build: pending final confirmation.
Manual camera and gallery testing: pending verification.
Screenshots / Media
Not applicable. This change affects native Android image processing.
Platforms Affected
Notes / Comments
The implementation currently uses a maximum bitmap dimension target of 2048 pixels. Feedback is welcome on whether this should be configurable or derived from the requested image dimensions to preserve the plugin's existing behavior.