[benchmarker/scd] Remove shared subscription management by individual users - #1672
Merged
mickmis merged 3 commits intoSep 9, 2026
Merged
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 26, 2026 21:24
mickmis
approved these changes
Sep 8, 2026
| @@ -199,85 +198,7 @@ def select_dss_instance(self) -> DSSInstance: | |||
| ) | |||
|
|
|||
| def get_utm_actions(self, flight: Flight) -> Iterable[FlightAction]: | |||
Contributor
There was a problem hiding this comment.
Delete this method and just use get_create_actions in callers?
Member
Author
There was a problem hiding this comment.
I think that's certainly reasonable in the current state where this doesn't do anything else, but I think it's probably valuable to encapsulate the implementation detail of "the only UTM action we currently have is to create stuff" from the abstraction/interface of "get all the UTM actions to perform"
…user-sub-management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #1666, SCD subscriptions can be established via actions prior to scenarios of interest. This allows us to remove subscription management from individual virtual users' workflows which reduces complexity and ways things can go wrong. This PR executes that workflow reduction/simplification.
The configuration schema change would be a breaking change, but benchmarker is not yet at initial release so I don't think we need to start tracking this yet. We will track breaking changes starting from official initial offering of benchmarker, but this will require a few more things (e.g., minimum usage documentation).
Verified to work normally (judged qualitatively; no failures due to missing subscriptions); timeline overview from one of the scenarios: