[benchmarker/scd] Improve resilience of subscription management - #1673
Merged
mickmis merged 1 commit intoSep 8, 2026
Merged
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 27, 2026 17:51
mickmis
approved these changes
Sep 8, 2026
| f"F3548 Action: Checking if subscription '{spec.subscription_id}' exists before deleting..." | ||
| ) | ||
| deleted = False | ||
| for dss_instance in dss_instances: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When benchmarker is stopped abnormally, the permanent subscriptions can be left in an unusable state since they have dependent operational intents which make them undeletable. This PR resolves that problem by also deleting the dependent operational intents when necessary to perform the specified subscription management task, so this allows easy benchmarker recovery of a dirty stateful deployed system. It also prints additional information about any residual errors to make debugging easier.
Tested stacked on #1672 locally with a modified configuration to elicit the new behavior more easily.