Modernize - #48
Merged
Merged
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
- Added new Python Hebrew workflow file - Updated Ruby workflow to use newer Ruby versions (2.7-3.3) and latest actions - Fixed Python package setup.py files for both Arabic and Hebrew modules - Made wandb optional in Python code to avoid breaking builds - Modified test configuration files with correct parameters - Updated torch dependency to support newer versions (<3.0.0 instead of <2.0.0) - Added test data files for Hebrew module testing
This was referenced Sep 2, 2026
…pt, modernized matrix + ranges kept Conflict resolution: python/* takes the modernization side; ruby.yml takes main (3.3/3.4, v7); python-arabic.yml hand-merged (main lint job + branch dependency-review/infer-train matrix 3.8-3.12 + security-scan; branch codeql job dropped — duplicates the repo configured default CodeQL setup; PROTOCOL_BUFFERS env kept). Re-applied main F821 process_losses fix the side-resolution dropped; ruff clean + formatted across python/.
- drop EOL python 3.8 from matrixes (list[int] annotations need 3.9+) - hebrew train job: create data/train + data/eval test files the test_cbhg config actually reads (was data/test) - drop the hebrew workflow codeql job (duplicates the repo configured default CodeQL setup — same rationale as #61) - bump actions to checkout@v7 / setup-python@v7 - ruff: fix 5 I001 import sorts + format (verified in a clean checkout — local untracked dirs had masked isort classification)
The dataset loader reads config["eval_file_name"] for the validation set (train.yml already uses it); test_cbhg.yml predates the rename, so the CI train job died with KeyError after the data-prep fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.