Skip to content

fix: string precisions for Modal entrypoints #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronaldtse merged 1 commit into from
Aug 29, 2026
Merged

fix: string precisions for Modal entrypoints #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/gpu/modal_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def _load_pairs(path: Path) -> list[tuple[str, str]]:
timeout=2 * 3600,
volumes={**CHECKPOINT_VOLUMES, **DATASET_VOLUMES, "/outputs": MODELS_VOLUME},
)
def export_model(model_id: str, precisions: list[str]) -> dict[str, str]:
def export_model(model_id: str, precisions: str = "fp32,fp16,int8") -> dict[str, str]:
import sys

sys.path.insert(0, "/root/interscript-ml/src")
Expand All @@ -219,7 +219,7 @@ def export_model(model_id: str, precisions: list[str]) -> dict[str, str]:
metadata_path,
readme_path.read_text(encoding="utf-8"),
out_dir,
precisions=tuple(precisions),
precisions=tuple(p.strip() for p in precisions.split(",") if p.strip()),
)
MODELS_VOLUME.commit()

Expand Down Expand Up @@ -254,7 +254,9 @@ def export_model(model_id: str, precisions: list[str]) -> dict[str, str]:
timeout=5 * 3600,
volumes={**CHECKPOINT_VOLUMES, **DATASET_VOLUMES, "/outputs": MODELS_VOLUME},
)
def parity_model(model_id: str, precisions: list[str], limit: int = 0) -> dict[str, str]:
def parity_model(
model_id: str, precisions: str = "fp32,fp16,int8", limit: int = 0
) -> dict[str, str]:
"""WO03 gate on Modal: torch reference vs ONNX decode over the test
split; writes the parity block into each zip (strict gate enforced)."""
import sys
Expand Down
Loading