fix: string precisions for Modal entrypoints - #81
Merged
Conversation
ronaldtse
pushed a commit
that referenced
this pull request
Sep 3, 2026
The string-default refactor (#81) fixed export_model's usage but parity_model's loop still iterated the string per character — first char 'f' produced ara-diac-small-2.1-f.zip after the 12h-timeout run finished the reference decode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list[str] refactor broke modal run invocation - Parameter unparseable annotation. String + split, matching the original CLI shape.