Conversation
… form section into elements Bottom rung of the donation form stack. The data-models, currency-validator and form-section packages from iaux-donation-form land in src/elements/ia-donation-form/ as models/, currency-validator.ts and form-elements/ia-donation-section.ts. The 14 model files fold into six. The enums become as-const objects plus a type, since erasableSyntaxOnly rules out enum. The classes stay classes: offshoot, the monthly giving portal and the petabox banner all construct them. The section is ia-donation-section, sized off a 10px base font size variable like the item navigator so it renders the same under any root font size, with its CSS variables renamed to --ia-donation-section-*. story-template gets an importPath property so an element nested inside another component's directory shows the right import snippet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QnX6VHo3EJRzcKfhzBChCf
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 86.09% 86.58% +0.48%
==========================================
Files 67 76 +9
Lines 2244 2340 +96
Branches 486 501 +15
==========================================
+ Hits 1932 2026 +94
Misses 168 168
- Partials 144 146 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jbuckner
added this pull request to stack #101
September 15, 2026 00:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEBDEV-9051. Bottom rung of the donation form stack in WEBDEV-8602. Based on main.
The
data-models,currency-validatorandform-sectionpackages from iaux-donation-form land insrc/elements/ia-donation-form/asmodels/,currency-validator.tsandform-elements/ia-donation-section.ts. Everything else in the form depends on these three, which is why they go first.What changed beyond the move:
newthem.as constobjects plus a type, same asPlaybackModein the playback controls.erasableSyntaxOnlyrules outenum. Old-enum to new-union assigns fine, the reverse doesn't, so a consumer has to switch both sides of an API at once.donation-form-sectionisia-donation-section. It sizes off a 10px base font size variable like the item navigator does, so the badge and headline render at the same size under offshoot's 10px root and the demo's 16px root. CSS variables move to--ia-donation-section-*, text color follows--ia-theme-primary-text-color.CurrencyValidatortests the regex instead of matching with a global flag, which drops the statefullastIndex. Same behavior.story-templategets animportPathproperty. It derived the import snippet from the tag, which gaveia-donation-section/ia-donation-sectionfor an element that actually lives underia-donation-form/form-elements/. First nested element in the repo, so first time it mattered.Verified locally: build, full suite 672 passing, eslint and prettier clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QnX6VHo3EJRzcKfhzBChCf