Conversation
The edit-donation package from iaux-donation-form lands as ia-donation-edit-donation under src/elements/ia-donation-form/form-elements/, rendering ia-donation-section for its two steps. The petabox banner uses it on its own, so it gets its own story. Enums become as-const objects plus a type. CSS variables move to --ia-donation-edit-*, sized off a 10px base font size that is passed through to the sections. The strings go through msg(), the custom amount field gets an accessible name, and currency.js becomes a dependency. One inherited bug fixed: with the custom amount hidden, the "is the donor typing in the custom field" check compared null to null and came out true, so a preset set programmatically could end up with nothing selected. Guarded on the field existing, with a test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QnX6VHo3EJRzcKfhzBChCf
|
jbuckner
added this pull request to stack #101
September 15, 2026 00:02
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## WEBDEV-9051-migrate-donation-form-models #100 +/- ##
============================================================================
+ Coverage 86.58% 86.83% +0.25%
============================================================================
Files 76 78 +2
Lines 2340 2530 +190
Branches 501 548 +47
============================================================================
+ Hits 2026 2197 +171
- Misses 168 178 +10
- Partials 146 155 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEBDEV-9052. Stacked on #98. Third of the five in WEBDEV-8602.
donation-form-edit-donationmoves over asia-donation-edit-donation, with its story and tests on Vitest. The petabox banner uses this one standalone, so it has its own catalog entry.What changed beyond the move:
ia-donation-sectionfor its two steps instead ofdonation-form-section, and the enums areas constobjects plus a type.--ia-donation-edit-*(button colors, border, gap, font sizes, custom amount width, input border, badge and background pass-throughs to the sections). Everything is sized off a 10px base font size variable, which is also handed to the sections so the whole thing scales together. The two layout variables the element sets on its own host from the number of amounts are renamed too (--ia-donation-edit-amount-column-count,--ia-donation-edit-custom-amount-col-span). The old--editFormTextColorpass-through is gone, the section reads--ia-theme-primary-text-colordirectly.msg(), and the custom amount text field has anaria-label, it only had the visible "Custom: $" text beside it before.currency.jsis a new dependency, for the amount formatting.customAmountMode="hide", the "is the donor typing in the custom field" check comparednulltonulland came out true, so a preset set programmatically (say the banner switching amounts) could leave nothing selected until the donor clicked. Guarded on the field existing, with a test that fails on the old code.Verified locally: build, full suite 706 passing, eslint and prettier clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QnX6VHo3EJRzcKfhzBChCf