Skip to content

Add support for signed indexes in gather/scatter - #36

Merged
danieltowner merged 3 commits into
mainfrom
gather_scatter_signed
Oct 5, 2026
Merged

danieltowner merged 3 commits into
mainfrom
gather_scatter_signed

Conversation

@danieltowner

Copy link
Copy Markdown
Contributor

No description provided.

The stream output operator<< needed by boost test was in the global namespace where
its presence was ambiguious, which resulted in changes of behaviour across
different compilers. The operator has now been moved into xvec::simd
where it can be found reliably. This only affects testing, not the main
library itself.
- Updated tests to expose the issue
- refactored tests to use common code and simplify
- switched the implementation to using vec concepts for parameters
@@ -1,6 +1,6 @@
//===----------------------------------------------------------------------===//
//
// Copyright (C) 2021 Intel Corporation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright year should persist here as the first publication year.

Fixed copyright date in header.
@danieltowner
danieltowner requested a review from omalyshe October 2, 2026 12:33

@timmiesmith timmiesmith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danieltowner
danieltowner merged commit 52a69e4 into main Oct 5, 2026
4 checks passed
@danieltowner
danieltowner deleted the gather_scatter_signed branch October 5, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants