Repository navigation
Fix narrow bounds checking in generic gathers - #2
Closed
lpetersen-pixel wants to merge 1 commit into
Closed
lpetersen-pixel wants to merge 1 commit into
lpetersen-pixel wants to merge 1 commit into
Conversation
Contributor
|
@lpetersen-pixel Thanks for your repot and fix. Coincidentally I found something very similar recently and have a patch sitting on my machine waiting to be applied. I'll merge/compare with yours when I get back from cppcon. |
Author
no worries, thanks for the great talk :) |
Contributor
|
@lpetersen-pixel I took your basic fix and created a more comprehensive PR which also added verification and support for AVX-512 (#36). Thanks for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that generic gather did not work for certain values;
for a 128-element source,
1...128', anint8_tindex of 127 should return 128, but currently returns 0 as we callpartial_gather_from` which clamps the upper bound to the index types maximum and tests index < bound.solution: simply retain the full range size and compare safely; I would assume this adds a branch, but havent checked.