Skip to content

fix(test): add scope guard for logger sink cleanup in dynamic index tests #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rfsaliev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(test): add scope guard for logger sink cleanup in dynamic index tests #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/svs/index/vamana/dynamic_index_2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "svs/index/vamana/dynamic_index.h"
#include "svs/lib/float16.h"
#include "svs/lib/preprocessor.h"
#include "svs/lib/scopeguard.h"
#include "svs/lib/timing.h"

#include "svs/misc/dynamic_helper.h"
Expand Down Expand Up @@ -283,6 +284,13 @@ CATCH_TEST_CASE("Testing Graph Index", "[graph_index][dynamic_index]") {
global_callback_sink->set_level(spdlog::level::trace);
auto original_logger = svs::logging::get();
original_logger->sinks().push_back(global_callback_sink);
// The sink captures a local vector: remove it before the vector goes out of scope.
auto remove_sink = svs::lib::make_scope_guard([&]() noexcept {
auto& sinks = original_logger->sinks();
sinks.erase(
std::remove(sinks.begin(), sinks.end(), global_callback_sink), sinks.end()
);
});

// Load the base dataset and queries.
auto data = svs::data::SimpleData<Eltype, N>::load(test_dataset::data_svs_file());
Expand Down Expand Up @@ -495,6 +503,13 @@ CATCH_TEST_CASE("Dynamic MutableVamanaIndex Per-Index Logging Test", "[logging]"

auto original_logger = svs::logging::get();
original_logger->sinks().push_back(global_callback_sink);
// The sink captures a local vector: remove it before the vector goes out of scope.
auto remove_sink = svs::lib::make_scope_guard([&]() noexcept {
auto& sinks = original_logger->sinks();
sinks.erase(
std::remove(sinks.begin(), sinks.end(), global_callback_sink), sinks.end()
);
});

// Setup index
auto data = svs::data::SimpleData<Eltype, N>::load(test_dataset::data_svs_file());
Expand Down
Loading