Repository navigation
Conversation
rfsaliev
requested review from
ahuber21,
mihaic and
yuejiaointel
as code owners
November 13, 2026 13:47
rfsaliev
enabled auto-merge (squash)
November 13, 2026 13:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to logging resource management in the test suite for the Vamana dynamic index. The main change is the introduction of a scope guard to ensure that a locally-captured logging sink is properly removed before the associated vector goes out of scope, preventing potential resource leaks or invalid accesses.
Resource management improvements:
#include "svs/lib/scopeguard.h"todynamic_index_2.cppto enable use of scope guards for automatic resource cleanup.dynamic_index_2.cpp, wrapped the addition ofglobal_callback_sinkto the logger with a scope guard (svs::lib::make_scope_guard) to ensure the sink is removed from the logger's sinks vector when the test scope ends. [1] [2]