Honour CPU offload on H3, fix the training status, unblock large HF downloads - #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from field reports, plus the version bump.
CPU offload was silently dead on H3.
resolve_offloadtested the quantisation before the user's explicit choice, soOnreturned False for any 4-bit base. H3 is always 4-bit, so the one control that helps its users did nothing. Reordered:onandoffwin outright,autokeeps the old conservative behaviour. H3 breaks the "a quantized base already fits" assumption, because its base is 11.7GB and it is the clip activations that overflow the card.Progress was only emitted after a step finished, so the UI showed "loading model (nf4)" for the whole of step one. A slow first step read as a hung loader and sent a reporter and me chasing bitsandbytes. Now announced before the loop, with a test pinning the order.
Possible fix to #32
Large HF downloads failed.
hf_xetbecame a hard dependency ofhuggingface_hubat 0.32, and our floor was 0.23, so an older resolve could not fetch the 66GB H3 transformer at all. Floor raised.Also carries the
--no-sourceslauncher fix:--no-sources-packageonly exists in uv 0.10+, so the installer hard-errored for anyone older.