Pick the right CUDA wheel per GPU, surface integer versions H3 + clip window select - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick the right CUDA wheel per GPU, and stop warning on cards that work
Closes #33
Two field reports after v1.2.64, plus the clip-length controls a user asked for.
What changed
arch_list_coversreplaces exact matching with CUDA's within-major rule. Directional, so ansm_80 A100 against an sm_86-only wheel still warns, and sm_90 still does not cover sm_120.
sm_parse rule is written down: minor is the last digit, major is everything before.sm_120is (12, 0), not (1, 20). Reading it the other way puts the bug on exactly the Blackwellparts this is about.
set /acoercion instead of a pipedfindstrguard, so adriver answering
Unknown Erroryields 0 rather than string-comparing above 10 and winning.--torch-indexnow replaces torch. Project install first, then an exclusive--index-urlpass for torch and torchvision last, so nothing can re-resolve over the named index. torchvision
goes with it: a
+cu130torch beside a+cputorchvision imports fine and dies at the firstvision op.
covers the card. Gated: only a recognisable
+cpu/+cuXXXbuild is replaced automatically, so aROCm wheel or a nightly is left alone with a message instead.
--print-torch-indexreports what the driver said and which index would be used, and installsnothing. One line to paste into a bug report.
the first index with
sm_120, so that machine has one workable choice. Erroring would be worsethan what v1.2.64 did.
.inline-install.jsonrecords what the installer intended versus what landed.--torch-index.Clip controls
Trains on 107 frames (4.46s) per clip. The 17n+5 gridsnaps down, so asking for 5s trains on 4.458s, and that was silent until now.
peaks within 0.5GB of a still. Length costs time, not memory.
A
windows-latestCI job now runswebui.baton a real cmd interpreter with a stubbednvidia-smi, asserting all five decisions. There was no test workflow at all before, which is how
these shipped. It immediately earned its keep: it caught two bugs in my own rewrite, a missing
callthat let a.batshim hijack the script, and a delimiter that split12.0, 610.88so thedriver version was never read.