Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/navigation.css
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,16 @@
/* The tab row, and the phone menu's section list, hold every platform's own
sections; <html data-site>, set before the first paint
(lib/site-script.ts), shows one platform's. With no platform chosen, only
Concepts and Reference show. */
Concepts and Reference show. Each site in lib/platforms.ts needs its rule
here, the combinations too (test/site-switch.test.ts). */
:root:not([data-site]) a[data-platform],
:root[data-site="synapse"] a[data-platform]:not([data-platform="synapse"]),
:root[data-site="databricks"] a[data-platform]:not([data-platform="databricks"]),
:root[data-site="adf"] a[data-platform]:not([data-platform="adf"]),
:root[data-site="duckdb"] a[data-platform]:not([data-platform="duckdb"]) {
:root[data-site="duckdb"] a[data-platform]:not([data-platform="duckdb"]),
:root[data-site="adf-databricks"] a[data-platform]:not([data-platform="adf-databricks"]),
:root[data-site="adf-synapse"] a[data-platform]:not([data-platform="adf-synapse"]),
:root[data-site="adf-duckdb"] a[data-platform]:not([data-platform="adf-duckdb"]) {
display: none;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/site-script.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ import { platformIds } from "./platforms";
/** The script's source, for a <script> before the header. */
export function siteScript(): string {
const ids = JSON.stringify(platformIds);
return `(function(){try{var ids=${ids};var m=/^\\/docs\\/([a-z]+)(?:\\/|$)/.exec(location.pathname);var id=m&&ids.indexOf(m[1])>-1?m[1]:null;if(!id){var s=null;try{s=localStorage.getItem("ingestron-platform")}catch(e){}if(s&&ids.indexOf(s)>-1)id=s}if(id)document.documentElement.dataset.site=id}catch(e){}})();`;
return `(function(){try{var ids=${ids};var m=/^\\/docs\\/([a-z-]+)(?:\\/|$)/.exec(location.pathname);var id=m&&ids.indexOf(m[1])>-1?m[1]:null;if(!id){var s=null;try{s=localStorage.getItem("ingestron-platform")}catch(e){}if(s&&ids.indexOf(s)>-1)id=s}if(id)document.documentElement.dataset.site=id}catch(e){}})();`;
}
19 changes: 15 additions & 4 deletions test/site-switch.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { join } from "node:path";
import { runInNewContext } from "node:vm";
import { describe, expect, it } from "vitest";
import { headerTabs, siteSections } from "../lib/areas.js";
import { platformSections, sectionsOf, switchTarget } from "../lib/platforms.js";
import { platformIds, platformSections, sectionsOf, switchTarget } from "../lib/platforms.js";
import { siteScript } from "../lib/site-script.js";
import { tree } from "./tree.js";

Expand Down Expand Up @@ -83,11 +83,14 @@ describe("the header's tabs", () => {
expect(platformSections.length).toBe(6);
});

it("are hidden for other platforms by the stylesheet", () => {
// Every site, the combinations such as adf-synapse included: a site with no
// rule shows every platform's tabs.
it("are hidden for other platforms by the stylesheet, on every site", () => {
const css = readFileSync(join(process.cwd(), "app/navigation.css"), "utf8");
expect(css).toContain(":root:not([data-site]) a[data-platform]");
for (const id of ["synapse", "databricks", "adf", "duckdb"])
expect(css).toContain(
expect(platformIds).toContain("adf-synapse");
for (const id of platformIds)
expect(css, id).toContain(
`:root[data-site="${id}"] a[data-platform]:not([data-platform="${id}"])`,
);
});
Expand Down Expand Up @@ -117,6 +120,14 @@ describe("the script before the first paint", () => {
expect(run("/docs/reference/cli", "synapse", true)).toBeUndefined();
});

it("marks a combined site, such as adf-synapse, by its whole id", () => {
for (const id of platformIds) {
expect(run(`/docs/${id}`, null), id).toBe(id);
expect(run(`/docs/${id}/connectors`, "synapse"), id).toBe(id);
}
expect(run("/docs/reference/cli", "adf-duckdb")).toBe("adf-duckdb");
});

// In the root layout's <head>, which a page change never renders again: a
// <script> in a layout the browser renders after a page change never runs,
// and React reports it. PlatformMemory marks the page on each change.
Expand Down
Loading