Repository navigation
Header tabs: one site's tabs on the Data Factory combinations - #39
Merged
Merged
Conversation
The stylesheet had a rule for synapse, databricks, adf and duckdb only, so on adf-databricks, adf-synapse and adf-duckdb every site's tabs showed. The script before the first paint also read /docs/adf-synapse as no site. Each site in lib/platforms.ts now has its rule, and the tests check every site. Signed-off-by: The Architect <hello@ingestron.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On /docs/adf-synapse, /docs/adf-databricks and /docs/adf-duckdb the header showed every site's tabs, in a row that scrolled sideways: app/navigation.css hid other sites' tabs only for the four single-platform sites. Adds the three combinations' rules; the script before the first paint now reads a hyphenated site from the URL. The tests check every site in lib/platforms.ts, so a new site without its rule fails.