Repository navigation
feat(cypher): support scoped read-only CALL subqueries - #48
Merged
prrao87 merged 1 commit intoOct 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Relates to #20.
CALL { ... RETURN ... }supports a leading plain importing WITH, separate UNION branch scopes and exported values. Each input row evaluates its child query; every child result extends that row. Empty inner results, aggregates, duplicate inputs, ordering and name collisions follow the tested scope and multiplicity rules.The operator preserves entity/path values, streams one child at a time and yields after bounded polling work, including empty batches. Drop, errors and timeout release owned child streams. Procedures, YIELD and writes remain unsupported. Guides include executable examples, cache behavior, execution strategy and migration for Rust
ReadingClause::CallandLogicalOperator::{Apply, CallInput}. Python signatures are unchanged.Validation
Head
f2cc84c64898185bf8ea4826b276b61ea8b20b63; frozen parent32fee35e2aad15167a7d33ec0d9eee9b3d268b5b. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 1,183 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.This is a coordinated draft. Preserve its frozen-head outcomes and apply the shared corrections in the qualified integration; changing the actual target requires requalification. The accepted combined engine source is
7d2ef3e; its current-main documentation merge is5fe24cd.User impact
Read-only CALL subqueries support explicit importing WITH, correlations and exported rows, including zero/multiple inner rows and nested UNION scopes. Child-stream ownership and cancellation are tested. Procedures/writes remain outside the approved scope; docs and Rust migration notes are updated.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.