Conversation
The inference screen hard-coded camera framerate to DEFAULT_FPS (30) when building cameraDict. Add an editable "Camera FPS" number field, defaulting to DEFAULT_FPS, mirroring the existing "Max duration" input. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
feat(frontend): add editable Camera FPS field to inference modal
Rename the top bar label and the page title/OG tags from "LeLab" to "LeLab-Bellab" so it's always visually obvious which build (original vs. this fork) is running in the browser, since both serve on the same localhost:8000 origin. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
feat(frontend): brand landing header and tab as LeLab-Bellab
The recording request hard-coded fps: 30 for the dataset's overall sampling rate, separate from (and often mismatched with) each camera's own configured fps. lerobot's sanity check compares dataset fps against the robot's actual camera fps and errors on a mismatch — e.g. cameras configured at 15fps but the dataset requesting 30fps. Add an editable "Recording FPS" field to the recording modal, defaulting to the first configured camera's own fps (falling back to 30 if none is set), and use it instead of the hard-coded constant. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix(frontend): stop hard-coding recording fps to 30
bellabzhu
marked this pull request as draft
September 11, 2026 16:32
Author
|
Sorry, this pull request was a mistake. If you can delete it, I would appreciate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.