Repository navigation
Conversation
…anged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
AlikRakhmonov
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Same as hackolade/PostgreSQL#210, in this plugin. In
defaultValueHelper.js, the filternewDefault !== undefined && (!oldDefault || newDefault !== oldDefault)treats a falsy old default (false,0,"",null) as missing. An unchanged default is generated again asALTER COLUMN ... SET DEFAULT, next to the inline default of CREATE TABLE.Reproduced in Studio before the fix: boolean column, default
false, with a comment, inline defaults.Change
newDefault !== undefined && newDefault !== oldDefaultThe PostgreSQL fix is tracked in HCK-18624; this one has its own sub-task so the two can merge separately.
Regression test in Studio, same branch name
HCK-18634(hackolade/studio#6793).🤖 Generated with Claude Code